Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 #399

ronaldchl · 2015-05-15T23:07:45Z

…te when the first bit is one LOXI-67

rlane · 2015-05-15T23:10:06Z

LGTM

bsn-abat · 2015-05-15T23:13:52Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/147/
Test PASSed.

Sovietaced · 2015-05-15T23:24:39Z

ACK

bsn-abat · 2015-05-15T23:29:41Z

ABAT: START_MERGE: Log file at http://vss1/abat/2015.05.15.2329-m.loxigen.master/abat.log

anshaw · 2015-05-15T23:40:21Z

java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/IPv6Address.java

@@ -174,13 +174,13 @@ public static IPv6Address of(@Nonnull final byte[] address) {
                (address[0] & 0xFFL) << 56 | (address[1] & 0xFFL) << 48
                        | (address[2] & 0xFFL) << 40 | (address[3] & 0xFFL) << 32
                        | (address[4] & 0xFFL) << 24 | (address[5] & 0xFFL) << 16
-                        | (address[6] & 0xFFL) << 8 | (address[7]);
+                        | (address[6] & 0xFFL) << 8 | (address[7] & 0xFFL);



Loxigen Head commit floodlight/loxigen@bd96054 commit bd960540d2200dc256872e6143a22929b42463bc Merge: bc53ec0 b90552c Author: abat <abat@bigswitch.com> Date: Fri May 15 16:29:43 2015 -0700 Merge into master from pull request #399: Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 (floodlight/loxigen#399) commit b90552cca26e6da8b5c655f1de969794682b137e Author: Ronald Li <ronald.li@bigswitch.com> Date: Fri May 15 16:03:32 2015 -0700 Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67

bsn-abat · 2015-05-15T23:42:36Z

ABAT: ACCEPT: Successfully merged

In case you want to see the build log, check out :
Log file at http://vss1/abat/2015.05.15.2329-m.loxigen.master/abat.log
/cc

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 (#399)

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th by…

b90552c

…te when the first bit is one LOXI-67

anshaw reviewed May 15, 2015
View reviewed changes

bsn-abat merged commit b90552c into floodlight:master May 15, 2015

bsn-abat pushed a commit that referenced this pull request May 15, 2015

Merge into master from pull request #399:

bd96054

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 (#399)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 #399

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 #399

ronaldchl commented May 15, 2015

rlane commented May 15, 2015

bsn-abat commented May 15, 2015

Sovietaced commented May 15, 2015

bsn-abat commented May 15, 2015

anshaw May 15, 2015

bsn-abat commented May 15, 2015

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 #399

Fix IPv6Address.of(byte[]) to correctly deal with the 8th and 16th byte when the first bit is one LOXI-67 #399

Conversation

ronaldchl commented May 15, 2015

rlane commented May 15, 2015

bsn-abat commented May 15, 2015

Sovietaced commented May 15, 2015

bsn-abat commented May 15, 2015

anshaw May 15, 2015

Choose a reason for hiding this comment

bsn-abat commented May 15, 2015