Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static function to generate macAddress from IPv4 Multicast address #420

Merged
merged 6 commits into from
Sep 15, 2015
Merged

Added static function to generate macAddress from IPv4 Multicast address #420

merged 6 commits into from
Sep 15, 2015

Conversation

marymanohar
Copy link
Contributor

Reviewer: @ronaldchl @andi-bigswitch

LOXI-71

@bsn-abat
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/166/
Test PASSed.

andi-bigswitch
andi-bigswitch reviewed Aug 31, 2015
View reviewed changes
java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/MacAddress.java
int ipMask = 0x00EFFFFF;
ipLong = ipLong & ipMask;

MacAddress mac = MacAddress.of("01:00:5E:00:00:00");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to always re-allocated this Mac address every time. Make it a constant

private final static MacAddress MULTICAST_BASE_ADDRESS =  MacAddress.of("01:00:5E:00:00:00")

@bsn-abat
Copy link

bsn-abat commented Sep 9, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/170/
Test FAILed.

@bsn-abat
Copy link

bsn-abat commented Sep 9, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/171/
Test FAILed.

@bsn-abat
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/172/
Test PASSed.

ronaldchl
ronaldchl reviewed Sep 10, 2015
View reviewed changes
java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/MacAddress.java


/** Parse an IPv4 Multicast address and return the macAddress
* corresponding to the multicast IPv4 address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start on the line with one *.

@ronaldchl
Copy link
Contributor

Otherwise LGTM. And looks like there are some merge conflicts to be resolved.

@bsn-abat
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/173/
Test PASSed.

@ronaldchl
Copy link
Contributor

ACK

@bsn-abat
Copy link

ABAT: START_MERGE: Log file at http://vss1/abat/2015.09.15.2326-m.loxigen.master/abat.log

bsn-abat pushed a commit to floodlight/loxigen-artifacts that referenced this pull request Sep 15, 2015
Artifacts from floodlight/loxigen@4776c8a...3030a39
50185e1 
Loxigen Head commit floodlight/loxigen@3030a39
commit 3030a39d5a52f198ef997d6b1e0f41a33e48511b
Merge: 4776c8a 0f9126c
Author: abat <abat@bigswitch.com>
Date:   Tue Sep 15 16:26:40 2015 -0700

    Merge into master from pull request #420:
    Added static function to generate macAddress from IPv4 Multicast address (floodlight/loxigen#420)

commit 0f9126c1da22fc8d5003e46fb5535127d8f2abf1
Merge: 5cd56cb 4776c8a
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Tue Sep 15 16:14:35 2015 -0700

    Merge remote-tracking branch 'bigswitch/master' into my-loxigen

commit 5cd56cb61cb5ce8e727bb67e3c09d68c59a8c421
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Tue Sep 15 16:13:28 2015 -0700

    Fixed code review comments

commit fbc111d2804fce865b1a010dfaa5ca1685bc7a22
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 17:01:28 2015 -0700

    Fixed compilation error

commit 989491e689e464a06852bd9193eef58110135429
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 16:51:26 2015 -0700

    Fixed compilation warning

commit faf22f589f27b20335175699f1d226bef648f970
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 16:38:20 2015 -0700

    Fixed review comments and added JUnit testcases

commit c90917117a8df05131f67a8ed693e081a7ce466c
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Fri Aug 28 15:05:12 2015 -0700

    Added static function to generate macAddress from IPv4 Multicast address.
@bsn-abat
Copy link

ABAT: ACCEPT: Successfully merged

In case you want to see the build log, check out :
Log file at http://vss1/abat/2015.09.15.2326-m.loxigen.master/abat.log
/cc

@bsn-abat bsn-abat merged commit 0f9126c into floodlight:master Sep 15, 2015
bsn-abat pushed a commit that referenced this pull request Sep 15, 2015
Merge into master from pull request #420:
3030a39 
Added static function to generate macAddress from IPv4 Multicast address (#420)
smartnetworks pushed a commit to smartnetworks/loxigen-artifacts that referenced this pull request Jun 28, 2017
@smartnetworks
Artifacts from floodlight/loxigen@4776c8a...3030a39
d63707f 
Loxigen Head commit floodlight/loxigen@3030a39
commit 3030a39d5a52f198ef997d6b1e0f41a33e48511b
Merge: 4776c8a 0f9126c
Author: abat <abat@bigswitch.com>
Date:   Tue Sep 15 16:26:40 2015 -0700

    Merge into master from pull request #420:
    Added static function to generate macAddress from IPv4 Multicast address (floodlight/loxigen#420)

commit 0f9126c1da22fc8d5003e46fb5535127d8f2abf1
Merge: 5cd56cb 4776c8a
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Tue Sep 15 16:14:35 2015 -0700

    Merge remote-tracking branch 'bigswitch/master' into my-loxigen

commit 5cd56cb61cb5ce8e727bb67e3c09d68c59a8c421
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Tue Sep 15 16:13:28 2015 -0700

    Fixed code review comments

commit fbc111d2804fce865b1a010dfaa5ca1685bc7a22
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 17:01:28 2015 -0700

    Fixed compilation error

commit 989491e689e464a06852bd9193eef58110135429
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 16:51:26 2015 -0700

    Fixed compilation warning

commit faf22f589f27b20335175699f1d226bef648f970
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Wed Sep 9 16:38:20 2015 -0700

    Fixed review comments and added JUnit testcases

commit c90917117a8df05131f67a8ed693e081a7ce466c
Author: Mary Manohar <mary.manohar@bigswitch.com>
Date:   Fri Aug 28 15:05:12 2015 -0700

    Added static function to generate macAddress from IPv4 Multicast address.

(cherry picked from commit 50185e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marymanohar @bsn-abat @ronaldchl @andi-bigswitch