Added IPAddress#toInetAddress() convenience method #437
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| throw new IllegalArgumentException( | ||
| "Error getting InetAddress for the IPAddress " + this, e); | ||
| } | ||
| if (inetAddress == null) { |
There was a problem hiding this comment.
InetAddress.getByAddress never returns null, remove this check
There was a problem hiding this comment.
Oops, I didn't look at their implementation. Makes sense. Thanks!
|
Fixed in 3c99cdb. Thanks @andi-bigswitch |
|
Refer to this link for build results (access rights to CI server needed): |
| IPAddress<?> ip1 = IPAddress.of("2001:db8:abcd::1:2:3:4"); | ||
| InetAddress ia0 = ip0.toInetAddress(); | ||
| InetAddress ia1 = ip1.toInetAddress(); | ||
| assertEquals(ia0, InetAddress.getByName("201.202.3.4")); |
There was a problem hiding this comment.
One thing that might be good to double check is that we don't trigger any network interaction here (i.e., this unit test doesn't hang forever if you take the computer off the Internet).
I am always a little bit scared of those InetAddress classes talking to the net by themselves...?
There was a problem hiding this comment.
As long as you don't pass a hostname you should be good WRT DNS requests
There was a problem hiding this comment.
From the source code.
// if host is an IP address, we won't do further lookup
if (Character.digit(host.charAt(0), 16) != -1 || (host.charAt(0) == ':')) {
}
|
Otherwise LGTM - feel free to self-*ck |
|
SELF-ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2015.10.22.1938-m.loxigen.master/abat.log |
Loxigen Head commit floodlight/loxigen@8b8ac26 commit 8b8ac26edf425e61e34ec4a2e05f6505034569e2 Merge: 4d76743 3c99cdb Author: abat <abat@bigswitch.com> Date: Thu Oct 22 12:38:19 2015 -0700 Merge into master from pull request #437: Added IPAddress#toInetAddress() convenience method (floodlight/loxigen#437) commit 3c99cdb2767001373decc7a3277a676d26aed74e Author: Ronald Li <ronald.li@bigswitch.com> Date: Thu Oct 22 11:07:27 2015 -0700 Implement IPAddress#toInetAddress() directly in subclasses as suggested by @andi-bigswitch commit 79e06021411f96bdee9862342aab4b3985228036 Author: Ronald Li <ronald.li@bigswitch.com> Date: Wed Oct 21 16:29:04 2015 -0700 Added IPAddress#toInetAddress() convenience method
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
Added IPAddress#toInetAddress() convenience method (#437)
Reviewer: @andi-bigswitch @Sovietaced