Match: consistently hide Fields w/ broken prereqs LOXI-75 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, isExact(), isPartiallyMasked() and isFullyWildcarded() did not check whether the required prerequisites for a field had been set. get() and getMasked() did, leading to inconsistent results / NPEs. This makes all of the methods honor the prerequisite checks. It also adds a unit test checking the behavior.
|
LGTM 👍 |
|
I love me some unit tests |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM |
|
SELF-ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2015.11.20.1723-m.loxigen.master/abat.log |
bsn-abat
pushed a commit
to floodlight/loxigen-artifacts
that referenced
this pull request
Nov 20, 2015
Loxigen Head commit floodlight/loxigen@3cbb8c7 commit 3cbb8c7a915d9ce691fb7c3de06749c61cc54e4a Merge: 0ba42d4 3850039 Author: abat <abat@bigswitch.com> Date: Fri Nov 20 09:23:51 2015 -0800 Merge into master from pull request #447: Match: consistently hide Fields w/ broken prereqs LOXI-75 (floodlight/loxigen#447) commit 385003977cf417663f573ec41fba325cfbced40b Author: Andreas Wundsam <andreas.wundsam@bigswitch.com> Date: Thu Nov 19 19:44:51 2015 -0800 Match: consistently hide Fields w/ broken prereqs LOXI-75 Previously, isExact(), isPartiallyMasked() and isFullyWildcarded() did not check whether the required prerequisites for a field had been set. get() and getMasked() did, leading to inconsistent results / NPEs. This makes all of the methods honor the prerequisite checks. It also adds a unit test checking the behavior.
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
bsn-abat
pushed a commit
that referenced
this pull request
Nov 20, 2015
Match: consistently hide Fields w/ broken prereqs LOXI-75 (#447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @Sovietaced @wolverineav
Previously,
isExact(),isPartiallyMasked()andisFullyWildcarded()did not check whether the required prerequisites for a field
had been set. get() and getMasked() did, leading to inconsistent
results / NPEs.
This makes all of the methods honor the prerequisite checks.
It also adds a unit test checking the behavior.