Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fips-recast to registry #68

Merged
merged 1 commit into from
Mar 16, 2015
Merged

Add fips-recast to registry #68

merged 1 commit into from
Mar 16, 2015

Conversation

fungos
Copy link
Contributor

@fungos fungos commented Mar 15, 2015

Add recast to registry.
I've converted recast demo to glfw3 as I'd said it would be easier than get a fipsified SDL, but at the same time I've not tested on MacOS (I do not have one) or Windows (but will do soon).

Note: The glfw3 conversion is currently hosted at my fork, but the changes may get accepted upstream as the maintainer already confirmed it prefers glfw. I must only verify that premake4 builds correctly on MacOS and Windows before doing the PR there.

floooh added a commit that referenced this pull request Mar 16, 2015
Add fips-recast to registry
@floooh floooh merged commit 3bfdc19 into floooh:master Mar 16, 2015
@floooh
Copy link
Owner

floooh commented Mar 16, 2015

Awesome :) On OSX I'm still getting a compile error because GL/glu.h doesn't exist, as far as I can see only one GLU function is used in the tools: gluProject. One fips-friendly solution would be to replace this with glm (https://github.com/floooh/fips-glm), but I'm not sure whether the recast maintainer wants to bring in too many dependencies.

@floooh
Copy link
Owner

floooh commented Mar 16, 2015

One solution would be to select between gluProject and glm::project using a C define, and fips-projects could then simply set some RECAST_USE_GLM in the fips.yml or cmake files.

@floooh
Copy link
Owner

floooh commented Mar 16, 2015

PS: I've also written a ticket that fips needs some sort of import filter for cases like this where imports are only needed in specific situations (such as when building sample programs, but not when importing as lib): #69

@floooh
Copy link
Owner

floooh commented Mar 16, 2015

I pinged Mikko about this and he prefers a direct copy-paste to replace the dependency on GLU (if its really just that function): https://twitter.com/mikkomononen/status/577406986029035521

@fungos
Copy link
Contributor Author

fungos commented Mar 16, 2015

Nice! I will do this change and then do a little more work on the demo late today, thank you.

@fungos
Copy link
Contributor Author

fungos commented Mar 17, 2015

Done. Removed GLU dependency, hope now it will work on MacOS. Still not tested on Windows, will try tomorrow at work.

@floooh
Copy link
Owner

floooh commented Mar 17, 2015

I'm now having trouble with GL_TEXTURE_RECTANGLE_ARB not being defined on OSX, seems to be some include problem with glfw3.h. I'll try to find out more this evening.

@floooh
Copy link
Owner

floooh commented Mar 17, 2015

I have created a pull request fungos/fips-recast#1 to fix the OSX issues (and some minor CMakeLists.txt tweaks), looking at Windows next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants