Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the codebase for latest zig and zld changes #3

Closed
wants to merge 1 commit into from

Conversation

kubkon
Copy link
Contributor

@kubkon kubkon commented Jun 24, 2021

which include:

  • ast fixes
  • extern enum(i32) is now enum(i32)
  • there is no need for ZIG_SYSTEM_LINKER_HACK on macOS

The last change depends on ziglang/zig#9229


Hope you don't mind the PR @floooh; I used your awesome project as a test ground for my linker work so thought I might as well contribute fixes for latest master. If you feel this should go in a different branch than main, lemme know and I'll redo a PR onto a different branch!

which include:
* ast fixes
* `extern enum(i32)` is now `enum(i32)`
* there is no need for `ZIG_SYSTEM_LINKER_HACK` on macOS

The last change depends on ziglang/zig#9229
@floooh
Copy link
Owner

floooh commented Jun 25, 2021

Very cool thanks! I guess those changes are not compatible with the public 0.8.0 version? If so I will just merge them into a new 0.9.0 branch, which will then become main when zig switches to 0.9.0.

@floooh
Copy link
Owner

floooh commented Jun 25, 2021

PS: the changes to sokol_gfx.zig etc also need to be done in the original code generation scripts here (https://github.com/floooh/sokol/tree/master/bindgen), but I will take care of that.

@kubkon
Copy link
Contributor Author

kubkon commented Jun 25, 2021

Very cool thanks! I guess those changes are not compatible with the public 0.8.0 version? If so I will just merge them into a new 0.9.0 branch, which will then become main when zig switches to 0.9.0.

Correct, these changes require nightly build of the compiler and will not make it into a release cut until 0.9.0. Do you want me to re-push into 0.9.0 branch when you create it, or you'd rather take it from here?

@floooh
Copy link
Owner

floooh commented Jun 25, 2021

or you'd rather take it from here?

I'll take over, no worries :)

@floooh
Copy link
Owner

floooh commented Aug 5, 2021

Ok, there's now a branch zig-0.9.0 which works with the current zig dev version (not by merging this PR though, instead, the Zig bindings received another PR which makes them compatible both with 0.8.0 and 0.9.0, and the remaining fixes here in this repo where very few).

@floooh floooh closed this Aug 5, 2021
@kubkon kubkon deleted the zld-frameworks branch October 25, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants