Update to latest Odin version, LLVM17 and enable MacOS again #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also upgrade the |
|
Woah thanks! The LLVM version situation is a bit confusing on Odin. I seem to remember that anything beyond LLVM 14 isn't supported... But I guess if it works it works ;)
That would be much appreciated, thanks! |
|
From what I understand Odin doesn't support LLVM 15 and 16 because of breaking and unstable API changes, which stabilized later. Odin added support for 17 few months ago because it has huge performance improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to the latest odin build, and makes use of LLVM 17. On windows it comes by default, mac has
llvm@17in brew and on linux it's installed with a script.Note: the linux and macos odin releases are zipped twice for some reason, so the additional unzipping is a temporary hack.
MacOS was previously disabled because of deprecated
llvm@11but now works again.I also upgraded to
checkouts@v4sincev3triggered deprecated warnings.