Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol-d: initial support #115

Closed
wants to merge 6 commits into from
Closed

Conversation

kassane
Copy link
Contributor

@kassane kassane commented Dec 28, 2023

@kassane
Copy link
Contributor Author

kassane commented Dec 28, 2023

Wow!!

Change:

std::filesystem::path module_prefix = args.input;
L("module shaders.{};\n", module_prefix.stem().c_str());

Errors

MacOS

/Users/runner/work/sokol-tools/sokol-tools/src/shdc/sokold.cc:461:22: error: 'path' is unavailable: introduced in macOS 10.15
    std::filesystem::path module_prefix = args.input;
                     ^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/filesystem:909:24: note: 'path' has been explicitly marked unavailable here

Windows-MSVC

D:\a\sokol-tools\sokol-tools\ext\fmt\include\fmt\core.h(2530,46): error C2039: 'parse': is not a member of 'fmt::v10::formatter<const std::filesystem::path::value_type *,Char,void>' [D:\a\sokol-tools\fips-build\sokol-tools\win64-vstudio-debug\src\shdc\sokol-shdc.vcxproj]
          with
          [
              Char=char
          ] (compiling source file D:\a\sokol-tools\sokol-tools\src\shdc\sokold.cc)
D:\a\sokol-tools\sokol-tools\ext\fmt\include\fmt\core.h(1704,48): message : see declaration of 'fmt::v10::formatter<const std::filesystem::path::value_type *,Char,void>' [D:\a\sokol-tools\fips-build\sokol-tools\win64-vstudio-debug\src\shdc\sokol-shdc.vcxproj]

@kassane
Copy link
Contributor Author

kassane commented Dec 28, 2023

Done. Await review!!

@floooh
Copy link
Owner

floooh commented Jan 3, 2024

Ah, a bit tricky to keep track of the various discussion threads 😄 See my reply here:

kassane/sokol-d#5 (comment)

TL;DR: I will most likely start testing and reviewing in a couple of days.

@kassane
Copy link
Contributor Author

kassane commented Mar 23, 2024

When merge #120 it will be necessary to refactor this D lang support proposal.

@floooh
Copy link
Owner

floooh commented Mar 24, 2024

Yes, I'm currently changing the entire structure of sokol-shdc, but one goal is to make it easier to add new language outputs.

@floooh
Copy link
Owner

floooh commented May 9, 2024

Note: this PR has rotted since I completely changed the sokol-tools file structure. I'll take care of that on my side, and while at I'll also try to get all the other sokol-d things done.

floooh added a commit that referenced this pull request May 11, 2024
@floooh
Copy link
Owner

floooh commented May 11, 2024

Closing in favour of #128

@floooh floooh closed this May 11, 2024
@kassane kassane deleted the sokol-d_gen branch May 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants