Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[odin bindings] Exclude 'NUM' enum values #1029

Merged
merged 1 commit into from Apr 13, 2024

Conversation

jakubtomsu
Copy link
Contributor

There is no reason to have a NUM field at the end of an enum in Odin. Because unlike in C, Odin supports len(My_Enum). And the additional enum field also interferes with things like enumerated arrays and bit_sets.

@floooh floooh merged commit 8a8d797 into floooh:master Apr 13, 2024
24 checks passed
@floooh
Copy link
Owner

floooh commented Apr 13, 2024

Thanks! I'll try looking at your other PRs later today.

@jakubtomsu
Copy link
Contributor Author

Thank you! The other PRs I've submitted were mostly things I ran into while working on my game. But I never got around to submitting them upstream, so I did that now all at once :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants