Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GL context with DEBUG_BIT set when SOKOL_DEBUG is defined. #839

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

castano
Copy link
Contributor

@castano castano commented Jun 1, 2023

This mirrors the behavior of D3D11 and allows applications to use OpenGL debug output functionality.

Note that in non-debug contexts, the OpenGL implementation may not generate messages even if debug output is enabled, so this is required for debug output to work in all cases.

Questions:

  • Should we check for the presence of KHR_debug before enabling this?
  • Should this be an app_desc parameter instead of a compile time definition?

@castano
Copy link
Contributor Author

castano commented Nov 10, 2023

Any updates about this? It'd be great to merge this to make it easier to maintain my sokol_app branch.

@floooh
Copy link
Owner

floooh commented Nov 10, 2023

Thanks for the reminder. I'll try to give the PR a whirl this evening or over the weekend.

@floooh floooh self-assigned this Nov 10, 2023
@floooh
Copy link
Owner

floooh commented Nov 10, 2023

Ok, I'm not seeing any problems on my old and cheap Intel GPU laptop, guess that's a good sign ;)

Merging...

@floooh floooh merged commit cbebbcb into floooh:master Nov 10, 2023
25 checks passed
@castano
Copy link
Contributor Author

castano commented Nov 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants