New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render pass cleanup (implements #904) #985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time measurements for D3D11:
...these are just naively taking the time it takes to call those functions. |
floooh
force-pushed
the
issue904-pass-cleanup
branch
from
January 29, 2024 14:46
215a0f1
to
22464f7
Compare
… into generic code
…or, depth format and sample count
kassane
added a commit
to kassane/sokol-d
that referenced
this pull request
Feb 25, 2024
The issues on D binding persisted after this cleanup. 😞 |
@kassane after this PR is merged I'll take care of a couple of other small PRs piling up since then and then I plan to look at the D bindings again. |
kassane
added a commit
to kassane/sokol-d
that referenced
this pull request
Feb 29, 2024
* cleanup (ref: floooh/sokol#985) * more changes
This was referenced Mar 2, 2024
mityu
added a commit
to mityu/yoMMD
that referenced
this pull request
Mar 18, 2024
Catch up with the breaking change added by floooh/sokol#985 **only on macOS now**
mityu
added a commit
to mityu/yoMMD
that referenced
this pull request
Mar 18, 2024
Catch up with the breaking changes added by floooh/sokol#985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace granular getter functions in sokol_app.h withsapp_swapchain sapp_get_swapchain(void)
and this must fail when called outside the frame callback (to enforce correct usage)sg_desc.mtl_use_command_buffer_with_retained_references
, fixes Use retained command buffer in sokol_gfx #981)move(maybe at a later time)backend.cur_pipeline
up into generic statesokol_app.h: sapp_pixelformat, and allow to configure depth-buffer (none, depth-only, depth-stencil)move this into a later updateMerged: