Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render pass cleanup (implements #904) #985

Merged
merged 70 commits into from Feb 29, 2024
Merged

Render pass cleanup (implements #904) #985

merged 70 commits into from Feb 29, 2024

Conversation

floooh
Copy link
Owner

@floooh floooh commented Jan 28, 2024

Merged:

  • sokol-zig
  • sokol-odin
  • sokol-nim
  • sokol-rust
  • sokol-samples
  • pacman.c
  • pacman.zig
  • kc85.zig
  • doom
  • cimgui-starter-kit
  • v6502r
  • chips-test
  • qoiview

@floooh floooh self-assigned this Jan 29, 2024
@floooh
Copy link
Owner Author

floooh commented Jan 29, 2024

Some time measurements for D3D11:

  • 100k CreateRTV + CreateDSV + Release: 230ms
  • 100k sg_begin_pass/sg_end_pass(): 133ms
  • 100k CreateTexture2D + Release: 232ms

...these are just naively taking the time it takes to call those functions.

kassane added a commit to kassane/sokol-d that referenced this pull request Feb 25, 2024
@kassane
Copy link
Contributor

kassane commented Feb 25, 2024

The issues on D binding persisted after this cleanup. 😞

@floooh
Copy link
Owner Author

floooh commented Feb 25, 2024

@kassane after this PR is merged I'll take care of a couple of other small PRs piling up since then and then I plan to look at the D bindings again.

@floooh floooh marked this pull request as ready for review February 29, 2024 17:16
@floooh floooh merged commit 9f97a07 into master Feb 29, 2024
45 checks passed
@floooh floooh deleted the issue904-pass-cleanup branch February 29, 2024 18:14
kassane added a commit to kassane/sokol-d that referenced this pull request Feb 29, 2024
* cleanup (ref: floooh/sokol#985)

* more changes
mityu added a commit to mityu/yoMMD that referenced this pull request Mar 18, 2024
Catch up with the breaking change added by
floooh/sokol#985

**only on macOS now**
mityu added a commit to mityu/yoMMD that referenced this pull request Mar 18, 2024
Catch up with the breaking changes added by
floooh/sokol#985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use retained command buffer in sokol_gfx
2 participants