Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme #5

Open
verhovsky opened this issue Jan 6, 2023 · 6 comments
Open

Light theme #5

verhovsky opened this issue Jan 6, 2023 · 6 comments
Assignees

Comments

@verhovsky
Copy link

Can you add a theme with a white background please?

Here's some suggestions for the colors (red green blue) from https://ai.eecs.umich.edu/people/conway/VLSI/VLSIText/PP-V2/V2.pdf page 215

rgb(102, 156, 124)
rgb(105, 188, 232)
rgb(207, 87, 129)

I used this svg file to color match https://4004.com/4004-50th-1st-cut-svg.html

@floooh floooh self-assigned this Jan 11, 2023
@floooh
Copy link
Owner

floooh commented Jan 12, 2023

I've been updating the colors palettes, and added a new theme called 'Contrast', which is essentially the original Visual6502 color theme with a white background, not live yet, but soon-ish.
Screenshot 2023-01-12 at 20 04 08

@verhovsky
Copy link
Author

Thank you. Could you make the background pure white please?

@verhovsky
Copy link
Author

verhovsky commented Jan 13, 2023

Gonna close this, I can set it to pure white locally now, if you prefer the grey.

@floooh
Copy link
Owner

floooh commented Jan 13, 2023

Is there a specific reason why you need it pure white btw?

In any case the new palette is defined here (the last entry with 0.8 is the background color):

v6502r/src/ui.cc

Lines 755 to 767 in c2f1a61

if (ImGui::MenuItem("Contrast")) {
gfx_set_layer_palette(false, {
{
{ 1.0f, 0.0f, 0.0f, 1.0f },
{ 0.8f, 0.5f, 0.0f, 1.0f },
{ 1.0f, 0.0f, 1.0f, 1.0f },
{ 0.3f, 1.0f, 0.3f, 1.0f },
{ 1.0f, 0.3f, 0.3f, 1.0f },
{ 0.5f, 0.1f, 0.75f, 1.0f },
},
{ 0.8f, 0.8f, 0.8f, 0.0f }
});
}

...or if you want to override the default palette, that's defined here now:

v6502r/src/gfx.h

Lines 20 to 30 in c2f1a61

static const gfx_palette_t gfx_default_palette = {
{
GFX_CSSRGB(0xf50057, 1.0f),
GFX_CSSRGB(0xffeb3b, 1.0f),
GFX_CSSRGB(0xff5252, 1.0f), // unused?
GFX_CSSRGB(0x7e57c2, 0.7f),
GFX_CSSRGB(0xfb8c00, 0.7f),
GFX_CSSRGB(0x00b0ff, 1.0f),
},
{ 0.1f, 0.1f, 0.15f, 1.0f }
};

@floooh
Copy link
Owner

floooh commented Jan 13, 2023

FYI: I'm going to change the background color of the Contrast theme to white, will upload the WASM version some time this evening.

@verhovsky
Copy link
Author

verhovsky commented Jun 4, 2023

Could you please set imgui to light colors when selecting the Contrast theme as well? You already have some (presumably unused) code related to this here

ImGui::StyleColorsLight();

P.S. I think "Light" would be a much better name than "Contrast".

@verhovsky verhovsky reopened this Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants