Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings from rspec #10

Closed
mdave16 opened this issue Jan 18, 2018 · 3 comments
Closed

warnings from rspec #10

mdave16 opened this issue Jan 18, 2018 · 3 comments
Assignees

Comments

@mdave16
Copy link

mdave16 commented Jan 18, 2018

I am using rufus, and when i run rspec with tests, I get the following warnings:

/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.5/lib/et-orbi.rb:608: warning: assigned but unused variable - tu
/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.5/lib/et-orbi.rb:151: warning: instance variable @local_tzone_loaded_at not initialized
/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.5/lib/et-orbi.rb:153: warning: instance variable @local_tzone_tz not initialized

I imagine they are easy fixes, and just leftover from some change or another.

@mdave16
Copy link
Author

mdave16 commented Jan 18, 2018

noticed I was out of date, so updated to 1.0.8;

/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.8/lib/et-orbi.rb:682: warning: assigned but unused variable - tu
/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.8/lib/et-orbi.rb:163: warning: instance variable @local_tzone_loaded_at not initialized
/Users/me/.rvm/gems/ruby-2.4.2/gems/et-orbi-1.0.8/lib/et-orbi.rb:165: warning: instance variable @local_tzone_tz not initialized

same issues, but different lines. I know sometimes warnings can be ignored, but it's best practice not to.

Having looked at the files a bit more now, I can see why the non initialized vars are present, but also found that tu is on line 700 and nowhere else. Is it needed?

@jmettraux jmettraux self-assigned this Jan 19, 2018
@jmettraux
Copy link
Member

Many thanks!

@jmettraux
Copy link
Member

1.0.9 has been pushed to RubyGems and it includes the fix.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants