Should fix varying toolbar height after scrolling

[adamaviner]

Should fix varying toolbar height after scrolling, using scrollMaxDp instead of scrollMax, and changed the toolbar translation calculations

[florent37]

Thanks for your contribution. I checkout your branch and tested into my smartphone.
Did you test it ? I have an issue with it, I have a strange behavior with your modification

[adamaviner]

It works fine for me, I think the problem is that I hardcoded the heights of the status bar and toolbar in
line 104 : this.scrollMax = settings.headerHeight - (56 + 24);
Probably a bad idea.
Specifically it seems like using the transparent status bar, causes the 24dp of overlap there...
I think I need to measure the actual heights and presence in runtime or something,
not sure how to do that yet.

[florent37]

Yes it would be better if you get the real toolbar & status height. (maybe using viewtree observer on toolbar, etc. and http://stackoverflow.com/questions/3407256/height-of-status-bar-in-android)

And don't forget that some devices have transparent statusbar ;)

[florent37]

I closed this pull request but send me another when you have a new fix :) And I know you will find a really good fix ! 😄

thanks again for your contribution, I really appreciate it 👍