Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching ignores the host #4

Open
rpgoldman opened this issue Feb 2, 2021 · 0 comments
Open

Matching ignores the host #4

rpgoldman opened this issue Feb 2, 2021 · 0 comments

Comments

@rpgoldman
Copy link

I have a library that needs to pull the same path from 2 different hosts. I couldn't get this to work, and that's because urllib3-mock ignores the host property of the url. It should be able to add a host property to the set of urls and, if that property is not None, check it.

It's not great that the terminology used here is "URL" but what is meant is "that part of the URL that follows the host spec."

Maybe add a check to the url and raise an error if the user provides a value with a : in it, where presence of the colon is diagnostic of a full URL, instead of just a path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant