Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Bumped to 1.4.0, added ability to deal with nbproc > 1 #21

Merged
merged 6 commits into from Feb 13, 2015

Conversation

gshively11
Copy link
Contributor

This still needs some work (i.e. fixing cloudkick, some cleanup), but it seems to be working for me. To clarify what this is fixing, using nbproc > 1 in your haproxy.cfg will result in a pid file that has multiple pids. Previous code expected a single line pid file.

Could use some assistance fixing cloudkick as I'm not sure what it's doing. Let me know if you'd like me to clean up anything else.

@flores
Copy link
Collaborator

flores commented Feb 11, 2015

Nice.

Cloudkick is pretty much dead (bought by Rackspace), but the idea was metrics collected. We may be able to do this nicely to ingest via various XML/JSON formats by simply splitting csv output from the stats socket. In other words, maybe we just ditch that feature and then do something new as a feature for different metrics ingest systems. (ie: Logstash, etc)

I am leaving this pull open for now while waiting for some forks and contribs, but it looks good to me on a scroll. If no input I will cut 1.4.0 in a couple weeks.

@gshively11
Copy link
Contributor Author

Would love to see some json outputs from the tool, may try to work on that later. Sorry for polluting the commit history, I kept publishing stuff before verifying it actually worked.

I was getting inconsistent behavior from the stats socket, which was fixed by forcing the convention that only the stats socket bound to process 1 would actually get used. In the event of nbproc > 1, we should probably accept the targeted process(es) as an argument, but I didn't want to do the work on that yet since the aforementioned convention solved my problem.

@flores
Copy link
Collaborator

flores commented Feb 13, 2015

No worries and thank you for the fixes. I am going to merge this into Master and create tickets to remove Cloudkick (to see if anyone objects) and create JSON output. Feel free to make more!

Still not coding btw, so sorry I've not sent a pull for some of this stuff. Hoping for some community help while I focus on other things <3

flores pushed a commit that referenced this pull request Feb 13, 2015
WIP: Bumped to 1.4.0, added ability to deal with nbproc > 1
@flores flores merged commit 1ebe811 into flores:master Feb 13, 2015
@gshively11 gshively11 deleted the nbproc-support branch February 13, 2017 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants