Pass test_parse_big_integers on jruby #355
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I modified Generator.java and add INTEGER_HANDLER for passing test_parse_big_integers on jruby 9.2.0.0.
I think release of jruby 9.2.0.0 caused these failure. (I found this post http://jruby.org/2018/05/24/jruby-9-2-0-0)
Maybe this problem is mentioned in #336
note of implementation
The test failed because of
Java::JavaLang::ClassCastException: org.jruby.RubyBignum cannot be cast to org.jruby.RubyFixnum
.I avoid this excpetion by adding
INTEGER_HANDLER
and use this handler instead ofFIXNUM_HANDLER
andBIGNUM_HANDLER
.