Add support for emoji skintone #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianeckerstorfer
approved these changes
Sep 26, 2020
There was a problem hiding this comment.
@amirahaile Thanks so much for the PR, this is awesome, I didn't knew you can detect the skint one like that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, this library generates blank
aria-labelstrings for emojis with skin tones because the emoji dictionary this library is reliant upon,gemoiji, doesn't support emojis with skin tones.This PR strips the skin tone unicode from emojis before querying
gemojiso a description can be generated for thearia-label.Concerns
Apple adds a variant selector,
\uFE0F, to some emojis; Apple's unicode is what's used ingemoji.\u270C\uD83C\uDFFE\u270C\u270C\uFE0Fgemojiis first queried with the stripped emojis in case there was no skin color on the emoji or it doesn't include the variant. If that fails to get a match, the variant is added andgemojiis queried again. An emptyaria-labelis the fallback.