Refactored context management; Adding Ponoko -specific line properties.

[wayn3w]

This is the the same as the other Ponoko-specific pull request, but split into separate commits.

Not done:

• Changing the generators to use saved_context(). Happy to do this as a separate code change.
• Adding restoring the original point (get_current_point, move_to) to saved_context(). This had the potential to change a lot of code, including removing Boxes.restore(). Happy to do this as a separate code change.

[florianfesti]

Thanks for the updated patch. I am currently traveling so it may take a few days longer to take a look at it.

[florianfesti]

Ok, this looks really good. I split the patches even more (separating the color from the save_context part and moving the GPL header into a separate patch). I'll do some more testing tomorrow and then push the whole set.

Minor nit picks so far: The changes to universalbox change the color from red (1.0, 0, 0) to blue.
Looks like formats needlessly imports Colors
But I'll just fix that myself.

[wayn3w]

Great! Would you like me to refactor the generators to use the save_context once you merge? Wayne

…

On Sat, Feb 2, 2019 at 3:36 PM Florian Festi ***@***.***> wrote: Ok, this looks really good. I split the patches even more (separating the color from the save_context part and moving the GPL header into a separate patch). I'll do some more testing tomorrow and then push the whole set. Minor nit picks so far: The changes to universalbox change the color from red (1.0, 0, 0) to blue. Looks like formats needlessly imports Colors But I'll just fix that myself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADAVqT-fx29kKdFa_JkVbLPXdotoIzx9ks5vJfbngaJpZM4aL8Bz> .

[florianfesti]

I already started work on the generators based on the old patch. I'll probably just adapt that one.

Unfortunately this all means I need to replace the .move() method with a context manager, too.

[wayn3w]

If there's something in particular you'd like me to do re: this update, let me know; otherwise I'm going to work with another concept I've been thinking about. Wayne

…

On Sat, Feb 2, 2019 at 5:30 PM Florian Festi ***@***.***> wrote: I already started work on the generators based on the old patch. I'll probably just adapt that one. Unfortunately this all means I need to replace the .move() method with a context manager, too. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADAVqZSlT2KGoa6zwM9CZkKmcVv_WvDCks5vJhF4gaJpZM4aL8Bz> .

[florianfesti]

Ok, I fixed the issues above and simplified the handling of the svg_Ponoko format a bit. I still kept you as sole author. I hope that's ok.

[wayn3w]

I have no objections to you being co-writer, or giving me sole credit. I'm just happy to contribute. Thank you. Wayne

…

On Sun, Feb 3, 2019 at 10:33 AM Florian Festi ***@***.***> wrote: Ok, I fixed the issues above and simplified the handling of the svg_Ponoko format a bit. I still kept you as sole author. I hope that's ok. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADAVqc-8Tu9M_0DTl6gkk0TDFZDKep20ks5vJwFjgaJpZM4aL8Bz> .

[florianfesti]

Ok, I pushed my changes to switch over to saved_context(). Still a few generators left that need more than just a few lines indented on level deeper.