Add a bottom to the divider tray. #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add support for the generation of a bottom for the divider tray. The bottom can be generated by passing the --bottom=True flag. This makes it possible to generate ./static/samples/DividerTray.jpg
florianfesti
requested changes
Feb 16, 2020
| # Bottom piece. | ||
| if self.bottom: | ||
| self.rectangularWall(facing_wall_length, side_wall_length, "ffff", | ||
| callback=[partial(self.generate_finger_holes, side_wall_length)], move="up") |
There was a problem hiding this comment.
This looks a bit fishy. Shouldn't the edge type be "e" for the sides that don't have a side wall attached? As happens when left_wall or right_wall is False?
There was a problem hiding this comment.
It looks like you might be right :-).
|
Ok, fixed the side edges of the bottom and commited as a0338a5 |
|
Oh, thanks for the patch! There are several people eager to use this new feature: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for the generation of a bottom for the divider tray.
The bottom can be generated by passing the --bottom=True flag.
This makes it possible to generate ./static/samples/DividerTray.jpg