Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to Enable Bed Bolts #468

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xloem
Copy link

@xloem xloem commented Dec 21, 2022

I enabled bed bolts. What is the origin of that term?

  • made NutHole.sizes into global HexSizes and added shaft diameter values
  • added non-metric values to HexSizes
  • added flags --bolts and --nut_dist and parsed passed bolt strings
  • enabled bed bolts in classes that use them, if --bolts is passed

EDIT:
Things that could be immediately done to improve this:

  • note: the bed bolt setup has incomplete design; the old code may not reflect a good plan
  • move bolts and nut_dist to i think FingerJointSettings
    • this may also make some bedBoltSettings redundant
  • remove if self.bolts from generators. pass the d2 and d3 bolt policies and detect whether or not to use them in the edges.
  • move HexSizes to its own module
  • add a comment here so Florian finds the changes

@xloem xloem force-pushed the nutsnbolts branch 2 times, most recently from 3ffa25f to 1d7e812 Compare December 21, 2022 19:33
@xloem xloem changed the title Nuts, Bolts Flag to Enable Bed Bolts Dec 21, 2022
@florianfesti
Copy link
Owner

First of all it is great someone is interested in this feature. I added this very early in the life of Boxes.py but never had any use of it myself. As such is is still very rudimentary and has many possible improvements. Also many details are missing a proper plan. So don't try too hard to understand what the code is trying to do.

As for your changes: Moving the bolt data to a global is a step in the right direction. I wonder if we even should move that into its own module.

I am not too keen on adding more global options. bolts and nut_dist could probably go into FingerHoleSettings.

Generators should not need to do if self.bolts but the edges should handle that. So the generator would just supply the number/patterns of bolts but not deal with the details. (The current code is fine to play a round and get a better idea how tings should work).

@florianfesti
Copy link
Owner

Bed bolts is hardware to assemble beds and other furniture. It's a screw that typically goes through a corner post and is anchored in the side board with a nut embedded after some distance.

While this feature here uses "normal" machine screws they are used in the same way as bed bolts. If a native speaker has suggestions for a better name I am really not that attached.

@xloem
Copy link
Author

xloem commented Jan 1, 2023

I had heard of them as "T-bolts", although I get the impression that they aren't used much anymore.

@florianfesti
Copy link
Owner

If the parameters move to the FingerJointSettings may be just "bolts" is specific enough.

@florianfesti
Copy link
Owner

Anything you need help with? Feel free to bug me if you get stuck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants