-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag to Enable Bed Bolts #468
base: master
Are you sure you want to change the base?
Conversation
3ffa25f
to
1d7e812
Compare
First of all it is great someone is interested in this feature. I added this very early in the life of Boxes.py but never had any use of it myself. As such is is still very rudimentary and has many possible improvements. Also many details are missing a proper plan. So don't try too hard to understand what the code is trying to do. As for your changes: Moving the bolt data to a global is a step in the right direction. I wonder if we even should move that into its own module. I am not too keen on adding more global options. Generators should not need to do |
Bed bolts is hardware to assemble beds and other furniture. It's a screw that typically goes through a corner post and is anchored in the side board with a nut embedded after some distance. While this feature here uses "normal" machine screws they are used in the same way as bed bolts. If a native speaker has suggestions for a better name I am really not that attached. |
I had heard of them as "T-bolts", although I get the impression that they aren't used much anymore. |
If the parameters move to the FingerJointSettings may be just "bolts" is specific enough. |
Anything you need help with? Feel free to bug me if you get stuck! |
I enabled bed bolts. What is the origin of that term?
NutHole.sizes
into globalHexSizes
and added shaft diameter valuesHexSizes
--bolts
and--nut_dist
and parsed passed bolt strings--bolts
is passedEDIT:
Things that could be immediately done to improve this:
bolts
andnut_dist
to i thinkFingerJointSettings
bedBoltSettings
redundantif self.bolts
from generators. pass the d2 and d3 bolt policies and detect whether or not to use them in the edges.HexSizes
to its own module