Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overdispersion #247

Merged
merged 26 commits into from
Mar 5, 2021
Merged

Overdispersion #247

merged 26 commits into from
Mar 5, 2021

Conversation

florianhartig
Copy link
Owner

No description provided.

@florianhartig
Copy link
Owner Author

@EttnerAndreas - can you have a look if you understand why this branch suddenly has a build error? This was created from the last update in master, but master checks out, and the branch previously also checked out!

@florianhartig
Copy link
Owner Author

p.s., Andreas, can you do a review of this? This mostly concerns the code in the functions that are used by users, which are not so major, it's mainly a slight change in the standard overdispersion function, and the introduction of this parametric version of the overdispersion function. I would like to merge this all asap and get 0.3.4 on the way

@EttnerAndreas
Copy link
Contributor

good job
looks like it is fixed, I would be interested if you changed something specific

currently I am reviewing the new fucntions

@florianhartig
Copy link
Owner Author

No, I didn't fix anything. Maybe this was just a travis problem, I didn't look at the error message, sometimes one just gets build errors because the tests run too long, and that can happen because the servers are overloaded, if you trigger a re-build, the error is gone!

OK, thanks for the help function check. From my side, the branch could be merged!

@EttnerAndreas EttnerAndreas merged commit 6e72fee into master Mar 5, 2021
@EttnerAndreas
Copy link
Contributor

okay, think the text might disappeared.
alright, well I already merged it, do we need further tests?
Interesting, I read a lot of those internet connection problems causing this error (56)

@florianhartig
Copy link
Owner Author

Hi Andreas, thanks, but if you do a review, please don't merge yet, I will always merge, just note what you think should be changed, or add improvements.

Absolutely nothing unclear about the help ;) ? I must be on fire then!

@EttnerAndreas
Copy link
Contributor

EttnerAndreas commented Mar 5, 2021

It is quite clear, nothing big but

  • for me, it would be interesting to get an easy answer on the benefits of 'refit = T' since it is computationally expensive

-The type changed from Pearson to PearsonChisq, Is there a way to implement both? might be useful to have further help with the application. When to switch from type 'DHARMa' to 'PearsonChisq'
: PearsonChisq focusses on any difference, while person focusses on difference in a direction (linear relationship) , right?

  • maybe depending on the audience a further explanation of over/under- dispersion, when it is useful

@florianhartig
Copy link
Owner Author

OK, thanks, I've made an issue for that!

@florianhartig florianhartig deleted the overdispersion branch March 5, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants