Update tests.R #261
Merged
Update tests.R #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotResiduals expects form as argument to specify the predictor
|
Hi Justin, thanks, this looks right to me, the issue is because the argument had a different name in the previous version of DHARMa, weird that this hasn't popped up as an error at some stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Florian,
I think there is an issue with the argument naming between
testQuantiles()andplotResiduals().plotResiduals()expects the predictor argument to be calledform, whereas it is calledpredictorthroughouttestQuantiles().If you need more information about the problem or some example to illustrate it, let me know.
Greetings,
Justin