Fix authorization, module expose and extend profile

[pwirth]

No description provided.

[florianmartens]

Thank you for opening a PR 👍🏽. Will look at it later today.

[florianmartens]

I'm trying to find some Passport strategies that use this approach (having the option to extend the profile) to stay idiomatic with the framework. Can you point to a couple other libraries that implement this? Personally, I think users should just perform a seperate lookup for these values after a user has authenticated themself.

[pwirth]

it is implemented similar in https://github.com/balanced-mt/passport-twitter-oauth2/blob/master/lib/strategy.js#L128 and https://github.com/jaredhanson/passport-twitter/blob/master/lib/strategy.js#L110

[florianmartens]

What would be the advantage here? This library already exports the Strategy for the use with e.g. NestJs.

Using NestJs, you can already use the Strategy like this:

import Strategy from 'passport-twitter-oauth2.0';
import { PassportStrategy } from '@nestjs/passport';


export default class TwitterStrategy extends PassportStrategy(
    Strategy,
    'twitter',
) {
 // -- snip --  
}

[pwirth]

since i changed from passport-twitter to this library, it was not working as i expected, so i changed it to work similar to that other library

import { Strategy, ... } from "passport-twitter-oauth2.0";
@Injectable()
export class TwitterStrategy extends PassportStrategy(Strategy, "twitter") {
    constructor(
        private readonly configService: ConfigService,
        private readonly userService: UserService,
        private readonly socialProfileService: SocialProfileService,
    ) {
        super({
            clientID: configService.getTwitterOAuth2ClientID(),
            clientSecret: configService.getTwitterOAuth2ClientSecret(),
            callbackURL: configService.getTwitterCallbackUrl(),
            clientType: "private",
            pkce: true,
            state: true,
            scope: ["offline.access", "users.read", "tweet.read", "follows.read", "like.read"],
        });
    }
}

[florianmartens]

Thank you for your contribution.