Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added currencylayer provider #36

Merged
merged 1 commit into from Jun 20, 2016
Merged

Conversation

pascal-hofmann
Copy link
Contributor

No description provided.

@pascal-hofmann
Copy link
Contributor Author

The failing Travis CI build is related to CentralBankOfCzechRepublicProvider.

@florianv
Copy link
Owner

Hey @phofmann-trust, thanks for the PR.

Can you rebase to the current master please ?

@pascal-hofmann
Copy link
Contributor Author

@florianv Rebased and StyleCI complaints fixed.

/*
* This file is part of Swap.
*
* (c) Pascal Hofmann <mail@pascalhofmann.de>
Copy link
Owner

@florianv florianv Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be:

/*
 * This file is part of Swap.
 *
 * (c) Florian Voutzinos <florian@voutzinos.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

You can add your authorship on the files you created, but the project remains my property.

@pascal-hofmann
Copy link
Contributor Author

Copyright fixed.

@pascal-hofmann
Copy link
Contributor Author

Any update on this? Would be great to have this merged. 👍

@florianv florianv merged commit 6d17142 into florianv:master Jun 20, 2016
@florianv
Copy link
Owner

Thanks for your contribution @phofmann-trust !

@florianv
Copy link
Owner

This is now available in version 2.6.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants