history provider #43
Closed
history provider #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 28, 2016 23:38
Swap\CacheInterface accepts Swap\Model\QuotationRequest instead of Swap\Model\CurrencyPair. Caching libs and tests has been adjusted accordingly.
Swap::quote can accept also Swap\Model\QuotationRequest to retrieve historical rates if provider implements 'Swap\HistoricalProviderInterface'.
kramapet
force-pushed
the
add-history-provider
branch
from
643bc7c
to
db78466
Compare
- add Swap\HistoryProviderInterface::setDate - delete Swap\HistoryProviderInterface::fetchHistoryRate interface is extending Swap\ProviderInterface now
kramapet
force-pushed
the
add-history-provider
branch
from
db78466
to
921596f
Compare
|
Hello, thanks for your PR. @kramapet Can you resolve the conflicts and fix the style issues please ? |
kramapet
force-pushed
the
add-history-provider
branch
from
232e844
to
2378cce
Compare
|
I close this PR in favor of #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces a way to retrieve historical rates if provider implements Swap\HistoryProviderInterface.
To retrieve historical rate, see tests/Tests/SwapTest.php:44