Replace use of deprecated Buffer constructor (which could be used to …

…create an uninitialized Buffer of any size) with Buffer.from()

.travis.yml

@@ -1,9 +1,10 @@
 sudo: false
 language: node_js
 node_js:
-  - iojs
-  - '0.12'
-  - '0.10'
+  - "10"
+  - "9"
+  - "8"
+  - "6"
 after_script:
   - npm run coveralls
 branches:

index.js

@@ -13,9 +13,9 @@ function Concat(generateSourceMap, fileName, separator) {
   this.contentParts = [];
 
   if (separator === undefined) {
-    this.separator = new Buffer(0);
+    this.separator = Buffer.from('');
   } else {
-    this.separator = new Buffer(separator);
+    this.separator = Buffer.from(separator);
   }
 
   if (this.sourceMapping) {
@@ -37,7 +37,7 @@ Concat.prototype.add = function(filePath, content, sourceMap) {
   filePath = filePath && unixStylePath(filePath);
 
   if (!Buffer.isBuffer(content)) {
-    content = new Buffer(content);
+    content = Buffer.from(content);
   }
 
   if (this.contentParts.length !== 0) {

package.json

@@ -21,11 +21,11 @@
     "source-map": "^0.6.1"
   },
   "devDependencies": {
-    "jshint": "^2.8.0",
-    "tape": "^4.2.0",
-    "istanbul": "^0.3.21",
+    "coveralls": "^3.0.0",
     "faucet": "0.0.1",
-    "coveralls": "^2.11.4"
+    "istanbul": "^0.4.5",
+    "jshint": "^2.9.5",
+    "tape": "^4.9.0"
   },
   "files": [
     "index.js",

test/index.js

@@ -8,7 +8,7 @@ function testCase(description, options) {
     // content as Buffer
     var concat = new Concat(options.sourceMapping, options.outFile, options.separator);
     options.input.forEach(function(input, i) {
-      concat.add((input.fileName !== undefined ? input.fileName : 'test'+(i+1)), new Buffer(input.content), input.sourceMap);
+      concat.add((input.fileName !== undefined ? input.fileName : 'test'+(i+1)), Buffer.from(input.content), input.sourceMap);
     });
     t.equal(concat.content.toString(), options.output.content, 'should produce the right output');
     if (options.output.sourceMap)
@@ -344,3 +344,10 @@ testCase('should allow content without filename and produce no mapping for it',
     sourceMap: '{"version":3,"file":"out.js","sources":["test2","test3","test5"],"names":[],"mappings":";AAAA;AACA;ACDA;;ACAA;AACA"}'
   }
 });
+
+test('should not allocate an uninitialized buffer when passing a number', function(t) {
+  t.throws(function() {
+    new Concat(true, 'all.js', 234);
+  }, "passing a number as separator should throw");
+  t.end();
+});