Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support py3.6 and py3.9 #26

Merged
merged 12 commits into from Jul 5, 2021

Conversation

graingert
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #26 (9c00b4d) into master (ad6f4d0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          319       317    -2     
=========================================
- Hits           319       317    -2     
Impacted Files Coverage Δ
src/aiometer/_impl/amap.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6f4d0...9c00b4d. Read the comment docs.

Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lots of interesting things in here. I'm thinking of passing these in separate PRs just out of cleanliness and moving this forward without blocking on specific items.

Edit: looks like we can start with #25 which takes this isolated approach nicely.

setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, thanks. 3.6 support is cheap enough (only requiring contextlib2 on 3.6) that I think we can be okay with adding support.

@florimondmanca florimondmanca merged commit 2a4e867 into florimondmanca:master Jul 5, 2021
@graingert graingert deleted the test-on-more-pythons branch July 5, 2021 18:21
@florimondmanca florimondmanca mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants