Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentelemetry-python ASGI integration #47

Merged
merged 3 commits into from
Sep 12, 2020
Merged

Conversation

florimondmanca
Copy link
Owner

@florimondmanca florimondmanca commented Sep 10, 2020

Checklist

  • This project is explicitly related to ASGI.
  • The new list entry contains a project name, URL and description.

What is this project?

https://opentelemetry-python.readthedocs.io/en/stable/instrumentation/asgi/asgi.html

OpenTelemetry is an in-the-works CNCF project for standardizing collection of telemetry metrics (via instrumentations) and their ingestion (via exporters) in a vendor-neutral way. https://opentelemetry.io/

It is supported by several vendors, such as Datadog, as well as other open source technologies (such as Prometheus).

opentelemetry-python ships with an ASGI middleware and some helpers to collect metrics from any ASGI apps.

Do you know about other similar projects?

No

If so, how is this one different?

/

Context
Found out about this while investingating encode/httpx#1264


Anyone who agrees with this pull request can add a 👍.

README.md Outdated Show resolved Hide resolved
@florimondmanca florimondmanca added the please vote Vote to confirm interest in adding this project to the list label Sep 10, 2020
@florimondmanca
Copy link
Owner Author

cc @majorgreys - Happy to get your feedback on whether this addition would be relevant, since (according to git commits…) I believe you contributed the ASGI instrumentation for OpenTelemetry! 😃

@majorgreys
Copy link

majorgreys commented Sep 10, 2020

Definitely relevant!

I would add there is also auto-instrumentation for Starlette and FastAPI (that draws on the ASGI middleware) in OpenTelemetry:

And while we are at it, also good to include that the Datadog Python APM client also provides an ASGI middleware for tracing:

@florimondmanca
Copy link
Owner Author

florimondmanca commented Sep 10, 2020

the Datadog Python APM client also provides an ASGI middleware for tracing

Yup great point. I thought I had added it already after the work done on migrating ddtrace-ASGI to dd-trace-py, but doesn't seem so!

also auto-instrumentation for Starlette and FastAPI

support for ASGI web frameworks as well and this repo would be a great place to publicize it when they are shipped.

This list is exclusively focused on ASGI and I try to keep framework-specific entries at an absolute minimum, so most likely won't be keen to add entries or mentions for those framework specific integrations here. They'd very much have a place in awesome-fastapi or any such list, though!

README.md Outdated Show resolved Hide resolved
@florimondmanca florimondmanca merged commit b4a9604 into master Sep 12, 2020
@florimondmanca florimondmanca deleted the fm/opentelemetry branch September 12, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please vote Vote to confirm interest in adding this project to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants