-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support django config detection for different versions (#170) #187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 96.55% 96.24% -0.31%
==========================================
Files 22 23 +1
Lines 522 533 +11
==========================================
+ Hits 504 513 +9
- Misses 18 20 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is lookng good. I'm updating Django versions in #189 so we properly test this on < 3.2 (via 2.2.*
) and 3.2+ (via 3.2.*
) on CI.
Great! That's would be a nice idea to test it on different django versions on CI |
@syth0le The versions updates got merged, feel free to rebase to see how this behaves against 2.2 and 3.2 :-) |
@florimondmanca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -105,3 +105,5 @@ venv.bak/ | |||
|
|||
# databases | |||
*.sqlite3 | |||
|
|||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found recently that you can add a global .gitignore
config to your machine like this:
touch ~/.gitignore
git config --global core.excludesfile ~/.gitignore
Helps prevent conflicts with developer dotfiles/dotdirs like these :) No problem including this though.
@syth0le I think codecov requires not reducing the coverage by default. We do have a code branch that's not run here (the one that's for < 3.2), and so the coverage decreased slightly. Not a problem, we can merge. I might look at if there's a way to have Codecov not fail a build for this reason… |
Closes #170
Fix problem with warnings that occurs after running pytests in any project with django version >= 3.2