Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support django config detection for different versions (#170) #187

Merged
merged 6 commits into from
Dec 11, 2021

Conversation

syth0le
Copy link
Contributor

@syth0le syth0le commented Dec 1, 2021

Closes #170
Fix problem with warnings that occurs after running pytests in any project with django version >= 3.2

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #187 (a50b8e8) into master (dd806cf) will decrease coverage by 0.30%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   96.55%   96.24%   -0.31%     
==========================================
  Files          22       23       +1     
  Lines         522      533      +11     
==========================================
+ Hits          504      513       +9     
- Misses         18       20       +2     
Impacted Files Coverage Δ
src/rest_framework_api_key/__init__.py 80.00% <66.66%> (-20.00%) ⬇️
tests/test_compatibility.py 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd806cf...a50b8e8. Read the comment docs.

Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is lookng good. I'm updating Django versions in #189 so we properly test this on < 3.2 (via 2.2.*) and 3.2+ (via 3.2.*) on CI.

@syth0le
Copy link
Contributor Author

syth0le commented Dec 5, 2021

Great! That's would be a nice idea to test it on different django versions on CI

@florimondmanca
Copy link
Owner

@syth0le The versions updates got merged, feel free to rebase to see how this behaves against 2.2 and 3.2 :-)

@syth0le
Copy link
Contributor Author

syth0le commented Dec 5, 2021

@florimondmanca
I think that all checks have been passed, but to be honest I dont know what to do with tests coverage (for 2 files). is it normal?
Or do you need to more than 95 percent of tests coverage for each file?

Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -105,3 +105,5 @@ venv.bak/

# databases
*.sqlite3

.idea/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found recently that you can add a global .gitignore config to your machine like this:

touch ~/.gitignore
git config --global core.excludesfile ~/.gitignore

Helps prevent conflicts with developer dotfiles/dotdirs like these :) No problem including this though.

@florimondmanca
Copy link
Owner

@syth0le I think codecov requires not reducing the coverage by default. We do have a code branch that's not run here (the one that's for < 3.2), and so the coverage decreased slightly. Not a problem, we can merge. I might look at if there's a way to have Codecov not fail a build for this reason…

@florimondmanca florimondmanca merged commit c121bfd into florimondmanca:master Dec 11, 2021
@chrismaddalena chrismaddalena mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemovedInDjango41Warning due to default_app_config
3 participants