Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme issue in day mode for miui #1694

Closed
HikaruIchijyo opened this issue Mar 25, 2022 · 7 comments · Fixed by #1697
Closed

Theme issue in day mode for miui #1694

HikaruIchijyo opened this issue Mar 25, 2022 · 7 comments · Fixed by #1697
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@HikaruIchijyo
Copy link

HikaruIchijyo commented Mar 25, 2022

In miui there is force dark mode for apps ig which breaks the day light theme if system is using dark theme & settings is on follow system.

Screenshot_2022-03-25-19-09-55-219_dev.patrickgold.florisboard.beta.jpg

Ig it is visible there is nothing visible i mean characters on the keyboard?

Maybe either ignore force dark mode or something?

@HikaruIchijyo HikaruIchijyo added the bug A bug report label Mar 25, 2022
@patrickgold
Copy link
Member

Xiaomi once again with their stupid dark mode solution nobody asked for. Will investigate into this. Does this only occur for the keyboard UI or also sometimes for the Settings UI too?

@patrickgold patrickgold added the area: kbd-ui Issues with the front-end of the keyboard rendering view label Mar 25, 2022
@patrickgold
Copy link
Member

Above linked PR is a possible fix for this. Could you please check the debug artifact APK (installs separately) if this works for you? Thanks in advance!

@patrickgold patrickgold added the bug-confirmed A confirmed and reproducible bug report label Mar 25, 2022
@HikaruIchijyo
Copy link
Author

Above linked PR is a possible fix for this. Could you please check the debug artifact APK (installs separately) if this works for you? Thanks in advance!

W8 where is debug apk🥲🥲

@patrickgold
Copy link
Member

Normally https://github.com/florisboard/florisboard/pull/1697/checks
Then Artifacts (top-right) > app-debug.apk

For above PR the workflow has weirdly not been triggered, but I just triggered it now and it should be there in a few minutes.

@HikaruIchijyo
Copy link
Author

HikaruIchijyo commented Mar 25, 2022

Normally https://github.com/florisboard/florisboard/pull/1697/checks
Then Artifacts (top-right) > app-debug.apk

For above PR the workflow has weirdly not been triggered, but I just triggered it now and it should be there in a few minutes.

Fixed

Screenshot_2022-03-25-21-24-01-806_dev.patrickgold.florisboard.debug.jpg

@patrickgold
Copy link
Member

Cool thanks for checking, will include the fix then in 0.3.15-beta01 later today!

@HikaruIchijyo
Copy link
Author

Cool thanks for checking, will include the fix then in 0.3.15-beta01 later today!

Np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants