Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glide typing not entering text #1703

Closed
crisp5 opened this issue Mar 26, 2022 · 9 comments · Fixed by #1756
Closed

Glide typing not entering text #1703

crisp5 opened this issue Mar 26, 2022 · 9 comments · Fixed by #1756
Labels
area: glide-typing Glide typing frontend / backend bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@crisp5
Copy link

crisp5 commented Mar 26, 2022

Short description

Glide typing does not enter text into textbox. Glide trail is visible, but ending the glide gesture does not insert a word. Tap typing works as expected.

Steps to reproduce

  1. Fresh install.
  2. Click on 'Gestures & Glide Typing' and Enable glide typing.
  3. Click on the 'Try out your setup' area (or any external app's text box) and start glide typing.

Environment information

  • FlorisBoard Version: 0.3.14 (also present in 0.3.15-beta01)
  • Install Source: 0.3.14 from F-Droid, 0.3.15-beta01 from GitHub
  • Device: Samsung Galaxy J7
  • Android: 8.1.0
@crisp5 crisp5 added the bug A bug report label Mar 26, 2022
@tsiflimagas
Copy link
Collaborator

Which app were you writing in?

@tsiflimagas tsiflimagas added the area: glide-typing Glide typing frontend / backend label Mar 26, 2022
@crisp5
Copy link
Author

crisp5 commented Mar 26, 2022

I initially tried using the new 'Try out your setup' box in Florisboard itself, but I also tried Firefox for Android, the phone's own Settings search and the stock Messages app.

@crisp5
Copy link
Author

crisp5 commented Mar 26, 2022

Killing the app while glide typing is enabled fixes the issue. I can reproduce the bad state by

  1. Having glide typing enabled and working
  2. Opening the Settings UI, disable glide typing, and killing the app from the Recent Apps screen
  3. Reopening the Settings UI and reenabling glide typing
    It'll stay in the bad state until I kill the app again.

@tsiflimagas
Copy link
Collaborator

It works for me in all these cases. Do you use English when using glide typing? It's not available for other languages yet. Also, did you try restarting the app?

@crisp5
Copy link
Author

crisp5 commented Mar 26, 2022

Yes, I'm using English (US) and restarting helps.
Missed an important step in my last comment, it should have been

  1. Kill the app with Glide disabled
  2. Open the app
  3. Tap on the "Try out" box to reload the keyboard
  4. Reenable glide
    So if the keyboard's already loaded, glide won't kick in until it's reloaded.

@tsiflimagas
Copy link
Collaborator

I see. These steps seem to work for me too, most of the times at least. Thank you for providing them, they could be proved to be valuable to Patrick for fixing known glide typing issues.

@junaidd09
Copy link

I am facing the same issue on my Pixel 4a. Restarted the app and it got fixed.

@Penguin-Guru
Copy link

Penguin-Guru commented Apr 4, 2022

Same issue, force stopping the app fixed it. My case was caused by an update (from F-droid) that disabled the gesture input setting for some reason. Pixel 5 running Graphene.

Incidentally, enabling the typing trail worked fine. The text just never appeared when I ended my gestures.

@patrickgold
Copy link
Member

Thanks for your bug report!

I can fully reproduce this bug. It was caused by a missing observer on the glideEnabled pref state, thus it would only load new glide data if the app was re-initialized by killing it or if the subtype was changed. Now with the fix of above PR it immediately loads the word data when you enable glide typing, thus the words are generated based on your glide.

If anyone wants you can try out the debug artifact, later today I will merge it in though and release this fix in 0.3.15-rc01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: glide-typing Glide typing frontend / backend bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants