Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold-Shift for Quick Capitilization #1764

Closed
realdep opened this issue Apr 7, 2022 · 3 comments · Fixed by #1832
Closed

Hold-Shift for Quick Capitilization #1764

realdep opened this issue Apr 7, 2022 · 3 comments · Fixed by #1832
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement

Comments

@realdep
Copy link

realdep commented Apr 7, 2022

As the title suggests, currently when you hold shift, only the first letter is capitilized. I suggest making it like a physical keyboard where as long as you keep shift held down, everything typed is capitilized.

This conflicts with the current hold-to-toggle (which is honestly very buggy) but nothing a simple option in the settings can't fix.

@mkoushan
Copy link
Contributor

mkoushan commented Apr 8, 2022

pls check out the Bug Reporting Guideline for reporting issues.

@Glitchy-Tozier Glitchy-Tozier added the proposal A proposal for a new feature or an enhancement label Apr 12, 2022
@patrickgold patrickgold added proposal-accepted An accepted proposal for a new feature or an enhancement area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) labels May 9, 2022
patrickgold added a commit that referenced this issue May 9, 2022
Pressing a char before long press timeout will suppress caps lock -> this allows to use the shift key like on PC
@patrickgold
Copy link
Member

Above commit/PR reworks the long press behavior of shift:

While the shift key is pressed down, you can type capitalized letters like on PC now. However normally the caps lock is activated after long press timeout. Above commit adds a logic that suppresses long press shift for caps lock if you enter a character before caps lock gets activated. This way when releasing the key it resets back to unshifted. If you don't enter a character then caps lock gets activated after long press timeout, like previously.

This behavior is the hybrid solution between keeping support for long press shift for caps lock and your proposal, I hope it satisfies your request close enough. Will be released in 0.3.16-beta02 in a few days. Thanks again for your suggestion!

@OoTMaestro
Copy link

Does this change allow for a shift+enter equivalent as one would find on a physical keyboard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants