Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitilized i in Turkish outputs "I" #1840

Closed
Atlas-19 opened this issue May 10, 2022 · 4 comments · Fixed by #1967
Closed

Capitilized i in Turkish outputs "I" #1840

Atlas-19 opened this issue May 10, 2022 · 4 comments · Fixed by #1967
Labels
area: kbd-layout Keyboard layout requests / issues / improvements bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Atlas-19
Copy link

Short description

Whenever I press shift and press i the keyboard outputs "I" instead of "İ".

A video demonstration:
https://user-images.githubusercontent.com/71735202/167711788-b5504a94-ea5f-4fb8-b56e-2f8bf29df0f3.mp4

Steps to reproduce

  1. Go to "Languages & Layouts"
  2. Create a Turkish keyboard subtype
  3. Press shift and type "i" using the aforementioned subtype

Environment information

  • FlorisBoard Version: 0.3.15 (80)
  • Install Source: F-Droid
  • Device: Lenovo TB-X606F & Samsung SM-J730F
  • Android: Android 10 & Android 9
@Atlas-19 Atlas-19 added the bug A bug report label May 10, 2022
@patrickgold
Copy link
Member

Thanks for your bug report!

Can reproduce your issue, however I don't really know how to fix it. The problem is, that the "i" is auto-capitalized for the ROOT locale in QWERTY and then this resulting key data is cached to avoid excessive memory allocation.

What you could do is use the Turkish-F or Turkish-Q layout for the time being, these have special selections for the "İ".

@patrickgold patrickgold added bug-confirmed A confirmed and reproducible bug report area: kbd-layout Keyboard layout requests / issues / improvements labels May 12, 2022
@demirdegerli
Copy link

demirdegerli commented Jul 25, 2022

Fixed this 🇹🇷
#1966

If I expand a little more, the pop-up values ​​for the letters "i" and "ı" are mixed with each other.

[EDIT]
My pr statically solves the issue and only for Turkish.
Please see @patrickgold's solution. It dynamically solves the issue for all related languages.

@patrickgold
Copy link
Member

@demirdegerli Please see #1966 why I think your PR does not address the issue, while my PR (#1967) does address the issue.

Both of you: could you try out #1967's debug artifact (installs separately and does not alter your main/beta installation) and test out the behavior of the I in QWERTY for both a Turkish and English subtype? The Turkish subtype should cause the capital I to have a dot, while the English one shouldn't have one. Thanks in advance!

@demirdegerli
Copy link

Ok, this commit (#1967) dynamically solves the issue for all languages. Exactly corrects me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-layout Keyboard layout requests / issues / improvements bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants