Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift + Space-swipe doesn't select text #1843

Closed
Glitchy-Tozier opened this issue May 12, 2022 · 3 comments · Fixed by #1880
Closed

Shift + Space-swipe doesn't select text #1843

Glitchy-Tozier opened this issue May 12, 2022 · 3 comments · Fixed by #1880
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Glitchy-Tozier
Copy link
Collaborator

Steps to reproduce

  1. Write text
  2. Try to select it using shift + space-swipe

Environment information

  • FlorisBoard Version: 0.3.16-beta01 (81)
  • Install Source: Google PlayStore
  • Device: Samsung Galaxy S9
  • Android: 10
@Glitchy-Tozier Glitchy-Tozier added the bug A bug report label May 12, 2022
@patrickgold
Copy link
Member

patrickgold commented May 12, 2022 •
edited
Loading

Thanks for your bug report!

I am aware of this issue, this bug was introduced in 0.3.16-beta01 and I will fix this before 0.3.16 stable.

@patrickgold patrickgold added bug-confirmed A confirmed and reproducible bug report area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) labels May 12, 2022
patrickgold added a commit that referenced this issue May 27, 2022
@patrickgold
Fix shift+space swipe not selecting text (#1843)
5d88058
@patrickgold patrickgold mentioned this issue May 27, 2022
Merged
@patrickgold
Copy link
Member

Above PR fixes the issue, shift+space should now be properly working again with the next beta release 0.3.16-beta04. I included the space swipe into the mass selection mechanism, which allows for fast updates without knowing the exact content. Once your finger lifts off the space bar, the content re-generates properly and the keyboard has proper context again.

Thanks again for reporting!

@Glitchy-Tozier
Copy link
Collaborator Author

Great to hear, looking forward to the update! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minor keyboard logic and Settings issues florisboard/florisboard
2 participants
@patrickgold @Glitchy-Tozier