Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys highlight on gestures #1846

Closed
daniandtheweb opened this issue May 12, 2022 · 1 comment · Fixed by #1844
Closed

Keys highlight on gestures #1846

daniandtheweb opened this issue May 12, 2022 · 1 comment · Fixed by #1844
Labels
area: gestures Issues with swipe gesture actions on the keyboard proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement

Comments

@daniandtheweb
Copy link

daniandtheweb commented May 12, 2022 •
edited
Loading

I just noticed that when performing a gesture like the one of deleting precisely or moving the cursor swiping on the spacebar the key initially pressed stops being visually highlighted. I think that highlighting the key until the gesture is completed could give the keyboard a more refined and consistent look.
@daniandtheweb daniandtheweb changed the title Button highlight on gestures Keys highlight on gestures May 12, 2022
@tsiflimagas tsiflimagas added the proposal A proposal for a new feature or an enhancement label May 13, 2022
@patrickgold patrickgold added proposal-accepted An accepted proposal for a new feature or an enhancement area: gestures Issues with swipe gesture actions on the keyboard labels May 13, 2022
patrickgold added a commit that referenced this issue May 13, 2022
@patrickgold
Fix active key not appearing pressed for moving gestures (#1846)
a650bfe
@patrickgold patrickgold mentioned this issue May 13, 2022
Merged
@patrickgold
Copy link
Member

Thanks for your proposal!

This was a rather quick fix, the initial key for moving gestures now stays active visually until you release your finger. Is parts of above linked PR, which will be released with 0.3.16-beta03!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: gestures Issues with swipe gesture actions on the keyboard proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Glide typing + gestures improvements / bug fixes florisboard/florisboard
3 participants
@patrickgold @tsiflimagas @daniandtheweb