Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space bar does not work on Korean #1947

Closed
Me0wzz opened this issue Jul 10, 2022 · 3 comments · Fixed by #1949
Closed

Space bar does not work on Korean #1947

Me0wzz opened this issue Jul 10, 2022 · 3 comments · Fixed by #1949
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Me0wzz
Copy link

Me0wzz commented Jul 10, 2022

Short description

Describe the bug in a short but concise way.
Space bar does not work on Korean.
English works fine.

Steps to reproduce

  1. Use Korean on Florisboard beta 0.4.0-alpha
  2. Type "ㄱ" + " " + "ㄴ"
    Expected Behavior: ㄱ ㄴ
    Actual Behavior ㄱㄴ

Environment information

  • FlorisBoard Version: 0.4.0-alpha
  • Install Source: F-Droid
  • Device: Pixel 6
  • Android: 12.1 Stock
@Me0wzz Me0wzz added the bug A bug report label Jul 10, 2022
@patrickgold
Copy link
Member

Seems to be an issue with the HangulUnicode composer. Space bar itself is fine and not effected, but the space gets basically "eaten" by the composer mentioned. Adding to the list of keyboard logic issues.

@Hayleia only if you want and have a bit of spare time, could you have a look into it? (as you implemented this composer and thus may notice the issue much easier)

@patrickgold patrickgold added bug-confirmed A confirmed and reproducible bug report area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) labels Jul 10, 2022
@Hayleia
Copy link
Contributor

Hayleia commented Jul 11, 2022

Seems like a more general issue. In Vietnamese with Telex too, when typing "e"+" "+"e" you get "ee". So it's probably not a problem in individual composers.

patrickgold added a commit that referenced this issue Jul 11, 2022
Issue only occurred for non-Appender composers
@patrickgold
Copy link
Member

Thanks Hayleia for the hint, this caused to to search the area I changed when I added the auto-spacing feature and indeed I accidentally forgot to check if the space should be actually deleted or not. For languages with the Appender this was never a problem because the composers toRead returned 0, but for languages like Korean this returns a positive integer and thus with the missing check causing the logic to believe there is a space to remove.

Above commit/PR contains the one-liner fix, if you want you can try out the fix, at least on my side I couldn't reproduce this issue at all anymore. Will be released in 0.4.0-alpha02.

patrickgold added a commit that referenced this issue Jul 18, 2022
Issue only occurred for non-Appender composers
snaik20 pushed a commit to snaik20/florisboard that referenced this issue Oct 8, 2022
Issue only occurred for non-Appender composers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants