Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in Polish layout #1960

Closed
MrBober opened this issue Jul 19, 2022 · 3 comments · Fixed by #1985
Closed

Mistake in Polish layout #1960

MrBober opened this issue Jul 19, 2022 · 3 comments · Fixed by #1985
Labels
area: kbd-layout Keyboard layout requests / issues / improvements proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement

Comments

@MrBober
Copy link

MrBober commented Jul 19, 2022

Default accent letter for z should be ż, not ź.

@MrBober MrBober added the proposal A proposal for a new feature or an enhancement label Jul 19, 2022
@tsiflimagas tsiflimagas added the area: kbd-layout Keyboard layout requests / issues / improvements label Jul 19, 2022
@pgronkievitz
Copy link

according to Wikipedia ż is over order of magnitude more common than ź, so it just makes sense to swap those two and make ż faster to type

@pgronkievitz
Copy link

I think it should be enough to just swap ź and ż like that (filenames irrelevant in this case as I didn't clone whole repository)

diff --git a/pl.json b/pl_new.json
index dc45da2..63a27bc 100644
--- a/pl.json
+++ b/pl_new.json
@@ -43,8 +43,8 @@
     },
     "z": {
       "relevant": [
-        { "$": "auto_text_key", "code":  378, "label": "ź" },
-        { "$": "auto_text_key", "code":  380, "label": "ż" }
+        { "$": "auto_text_key", "code":  380, "label": "ż" },
+        { "$": "auto_text_key", "code":  378, "label": "ź" }
       ]
     },
     "~right": {

@patrickgold patrickgold added the proposal-accepted An accepted proposal for a new feature or an enhancement label Jul 30, 2022
@patrickgold
Copy link
Member

Above PR fixes the popup ordering of z, ż is now prioritized over ź. Will be released in 0.4.0-alpha02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-layout Keyboard layout requests / issues / improvements proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants