Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete precisely with delete key swipe gesture #25

Closed
D3SOX opened this issue Oct 20, 2020 · 18 comments · Fixed by #97
Closed

Delete precisely with delete key swipe gesture #25

D3SOX opened this issue Oct 20, 2020 · 18 comments · Fixed by #97
Assignees
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Milestone

Comments

@D3SOX
Copy link

D3SOX commented Oct 20, 2020

Hi,
Thanks for maintaining this project.

I think you took a lot of inspiration from Gboard which I like since I switched from Gboard to Florisboard.

In the latest release you added the gestures (which I really like, especially the swipe down to hide) but the swipe left on delete key gesture only deletes full words.
In Gboard's version you can highlight something left to the cursor, let go and it deletes the highlighted text. I was wondering if it is possible for you to implement it as well.

@D3SOX D3SOX added the proposal A proposal for a new feature or an enhancement label Oct 20, 2020
@patrickgold
Copy link
Member

Hi D3SOX,

thanks for your suggestion. I didn't even know that Gboard had this feature. I'll add it to the todo list for v0.3.0!

@patrickgold patrickgold added the proposal-accepted An accepted proposal for a new feature or an enhancement label Oct 20, 2020
@patrickgold patrickgold self-assigned this Oct 20, 2020
@patrickgold patrickgold added this to the 0.3.0 milestone Oct 20, 2020
@HyknuF
Copy link

HyknuF commented Oct 31, 2020

Hi Together,

first of all, I just tested your keyboard and it looks really nice coded so far. Thanks for your effort and hopefully you keep going :-)

Nice to hear, that this feature will implemented soon, as it is really really handy. Thank you!

@kojid0
Copy link

kojid0 commented Nov 26, 2020

Openboard has this feature as well, so you might want to look at its source code on github, if needed :)

@D3SOX D3SOX mentioned this issue Nov 28, 2020
3 tasks
@RickyM7
Copy link
Contributor

RickyM7 commented Nov 28, 2020

Some changes that would greatly improve the way "Swipe to Delete" works in the app. The changes would be:

  1. Mark the characters while swiping.

  2. Don't interact with the keyboard while swiping.

  3. Do not lock "Swipe to Delete" after deleting only one word.

Example:

App in example: Simple Keyboard
Swipe to Delete Example

@patrickgold
Copy link
Member

Above commit adds precise character selection and deletion with the delete key, as in the image above. You still have the choice to have the previous 'Delete current word' gesture as selectable swipe action, alongside with no action at all (see image below). Will release with v0.2.5 shortly.

image

@HyknuF
Copy link

HyknuF commented Nov 30, 2020

Perfect, i will test it as soon as it's released 👍

@D3SOX
Copy link
Author

D3SOX commented Nov 30, 2020

Perfect, i will test it as soon as it's released 👍

It's already released. See https://github.com/florisboard/florisboard/releases/tag/v0.2.5

Working great so far.

@HyknuF
Copy link

HyknuF commented Nov 30, 2020

i can confirm, it works flawless so far 👍

@kojid0
Copy link

kojid0 commented Dec 1, 2020

Would it be possible to make delete on swipe more sensitive? Swiping fully from right to left only deletes a couple of words, so it takes a while to get rid of more
Example Florisboard (v0.2.6)
florisboard

Example Openboard:
openboard

@D3SOX
Copy link
Author

D3SOX commented Dec 1, 2020

@kojid0 I was thinking exactly the same. Another improvement that would be kinda cool: An option that makes it snap to words

@kojid0
Copy link

kojid0 commented Dec 1, 2020

An option that makes it snap to words

yeah!🔥

@patrickgold
Copy link
Member

Would it be possible to make delete on swipe more sensitive? Swiping fully from right to left only deletes a couple of words, so it takes a while to get rid of more

@kojid0 Hmm yeah you are right, I'll adjust the sensitivity.

An option that makes it snap to words

This sounds like a cool idea, will definitely implement it!

@RickyM7
Copy link
Contributor

RickyM7 commented Dec 2, 2020

Hmm yeah you are right, I'll adjust the sensitivity.

@patrickgold Will this adjust also apply to the option to move the cursor when swipe the space bar?

@patrickgold
Copy link
Member

@RickyM7 yes, because the same GestureHandler is responsible for both the space bar swipe and the precise delete swipe.

@RickyM7
Copy link
Contributor

RickyM7 commented Dec 2, 2020

@patrickgold That's great.

patrickgold added a commit that referenced this issue Dec 5, 2020
- Lowered distance threshold for move swipes
- Fix delete swipe not recognized when only one character was selected
@patrickgold patrickgold modified the milestones: 0.3.0, 0.4.0 Dec 6, 2020
@RickyM7
Copy link
Contributor

RickyM7 commented Dec 23, 2020

@patrickgold This has already been added, so I think this issue can be closed, however I have a note, the swipe gestures still have little sensitivity in v0.3.1.

@patrickgold
Copy link
Member

@RickyM7 Yes it's true that the precise key deletion feature has been implemented, but currently ot only snaps to characters. I will close this issue when the precision delete also works for words.

@RickyM7
Copy link
Contributor

RickyM7 commented Dec 23, 2020

@patrickgold Got it. Thank you for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants