Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "Move to End of Line" #340

Closed
Glitchy-Tozier opened this issue Feb 12, 2021 · 4 comments
Closed

Correct "Move to End of Line" #340

Glitchy-Tozier opened this issue Feb 12, 2021 · 4 comments
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report
Milestone

Comments

@Glitchy-Tozier
Copy link
Collaborator

(All of this also applies to "move to beginning of line)

Short description

This option (for long-presses and gestures) does not do what it says it does.

Move to end of line should be exactly that: Move the cursor to the end of the ONE horizontal line.
With the current behaviour, I suggest naming it something like "move to end of text"
Screenshot_20210212-120800_FlorisBoard.jpg

Environment information

  • FlorisBoard Version: 0.3.7
  • Install Source: Google PlayStore
@Glitchy-Tozier Glitchy-Tozier added the bug A bug report label Feb 12, 2021
@patrickgold
Copy link
Member

That's because the move to start/end of line sends hardware-emulated ALT left + arrow left/right keys to the target app, and the default behavior of this is t move to the end of the textfield (which in a single line works, but not in a multiline).

Will add this to my todo list.

@patrickgold patrickgold added the bug-confirmed A confirmed and reproducible bug report label Feb 12, 2021
@patrickgold patrickgold added this to the 0.5.0 milestone Feb 12, 2021
@Glitchy-Tozier
Copy link
Collaborator Author

I'm fine with it going to the end of the whole text. In that case it should be renamed though.

@patrickgold
Copy link
Member

Above commit fixes the "Move to start/end of line" behavior, it now correctly moves to the start/end of a line. I've also added a "Move to start/end of page" swipe action available to choose from in the gesture preferences, which brings the cursor to start/end of a text field (or in a document to the start/end of a page). Will be released in v0.3.8 this Sunday.

@Glitchy-Tozier
Copy link
Collaborator Author

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

No branches or pull requests

2 participants