Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long pressing delete button crashes florisboard #40

Closed
aha999 opened this issue Nov 13, 2020 · 4 comments
Closed

Long pressing delete button crashes florisboard #40

aha999 opened this issue Nov 13, 2020 · 4 comments
Assignees
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report
Milestone

Comments

@aha999
Copy link

aha999 commented Nov 13, 2020

When typing a text and long pressing delete button to delete bigger portions of text, florisboard crashes after 2 sec of holding delete button. Doesn't happen in all apps. Crashes in QKSMS

@patrickgold
Copy link
Member

Which version are you on? If it is v0.2.2, please consider updating to v0.2.3, as I have completely reworked the core. If it is v0.2.3, I'll have to investigate this bug further.

@patrickgold patrickgold added the bug A bug report label Nov 14, 2020
@patrickgold patrickgold self-assigned this Nov 14, 2020
@patrickgold patrickgold added the bug-confirmed A confirmed and reproducible bug report label Nov 17, 2020
@patrickgold
Copy link
Member

I've just released v0.2.4, which adds a crash handler and allows you to copy the captured error log. It would be great if you could try out the new version and if it still crashes when long pressing the deleted key, copy the error log and paste it here. This would help me a lot to find and eliminate the source of the crash. Thanks in advance!

@RickyM7
Copy link
Contributor

RickyM7 commented Nov 24, 2020

@patrickgold This bug occurred to me too.

Crash Log:


android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.	at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:6956)	at android.view.ViewRootImpl.invalidateChildInParent(ViewRootImpl.java:1119)	at android.view.ViewGroup.invalidateChild(ViewGroup.java:5244)	at android.view.View.invalidateInternal(View.java:13596)	at android.view.View.invalidate(View.java:13560)	at android.view.View.invalidate(View.java:13544)	at dev.patrickgold.florisboard.ime.text.keyboard.KeyboardView.invalidateAllKeys(KeyboardView.kt:341)	at dev.patrickgold.florisboard.ime.text.TextInputManager.updateCapsState(TextInputManager.kt:297)	at dev.patrickgold.florisboard.ime.text.TextInputManager.sendKeyPress(TextInputManager.kt:638)	at dev.patrickgold.florisboard.ime.text.key.KeyView$onFlorisTouchEvent$2.run(KeyView.kt:231)	at java.util.TimerThread.mainLoop(Timer.java:555)	at java.util.TimerThread.run(Timer.java:505)

@patrickgold
Copy link
Member

@RickyM7 thanks for sharing this crash log, this helped me identifying the error quickly! Interestingly the lines of code which produced this crash were introduced only after v0.2.3, which means that the delete key seems to have another source of crash (what @aha999 experienced in v0.2.2). I'll push a fix commit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

No branches or pull requests

3 participants