Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder keys to avoid tapping navigation pill instead of space. #58

Closed
teemue opened this issue Dec 2, 2020 · 7 comments
Closed

Reorder keys to avoid tapping navigation pill instead of space. #58

teemue opened this issue Dec 2, 2020 · 7 comments
Assignees
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Milestone

Comments

@teemue
Copy link

teemue commented Dec 2, 2020

This is a bit niche request, but I use Navigation Gestures-app and the pill always gets on the way (like in the picture attached). Some keyboards have a function to lift keyboard on the screen (pixelwise) enough to avoid misclicking. More elegant solution would be reordering of keys, so that bottom corners would have buttons but there would be empty space between them.
Screenshot_20201202-114018

@teemue teemue added the proposal A proposal for a new feature or an enhancement label Dec 2, 2020
@patrickgold
Copy link
Member

patrickgold commented Dec 2, 2020

Thanks for your suggestion, teemue. Afaik, Android apps can't automatically detect the pillow, as it is technically an overlay over the window FlorisBoard draws and is not in the way during the measurement process. It seems that it is possible to detect it via SystemInsets. I will add it to my todo list.

You could try to adjust the setting Keyboard > Bottom offset (for curved screens), which was intended to lift up FlorisBoard's keys by the specified dp to avoid curved screen's edges, for avoiding the pillow as well. Setting it to something like ~16dp to 20dp should suffice, although that varies from device to device. Let me know if this fixed your issue!

@patrickgold patrickgold added the proposal-accepted An accepted proposal for a new feature or an enhancement label Dec 2, 2020
@teemue
Copy link
Author

teemue commented Dec 2, 2020

I tried different offset values but tbh i didn't notice any difference. But thanks for considering this!

@patrickgold
Copy link
Member

patrickgold commented Dec 2, 2020

I just noticed that on the latest version the bottom offset is completely broken for some reason, this is why you didn't notice any difference...

Regarding your suggestion, after fixing the bottom offset preference I will also add a toggle to auto avoid a navigation overlays, as I think this is the best option to tackle this. Thanks for your input!

@patrickgold patrickgold added this to the 0.3.0 milestone Dec 2, 2020
@patrickgold patrickgold self-assigned this Dec 2, 2020
@patrickgold patrickgold modified the milestones: 0.3.0, 0.4.0 Dec 6, 2020
@patrickgold
Copy link
Member

I have tested around a bit with auto-avoiding the pillow but was unfortunately unsuccessful. As a temporary workaround you can use the bottom offset for pushing up FlorisBoard (which should start working with v0.3.0 again). I'll set the navigation avoidance on my todo list for 0.4.0.

@teemue
Copy link
Author

teemue commented Dec 7, 2020

Bottom offset works now. Unfortunately it's maximum value is not enough.

@patrickgold
Copy link
Member

@teemue I've tried around some auto-detection for this and unfortunately I wasn't able to implement something which could automatically avoid the navigation pillow. What I've done though is I've split up the Bottom offset preference into a portrait and landscape one and expanded the value range from 0...24 to 0...60 dp, which should be more than sufficient for avoiding the nav pillow. Will be released with v0.3.6 tomorrow.

@teemue
Copy link
Author

teemue commented Feb 2, 2021

Thanks. 60dp is enough indeed! This is the best solution I've seen on FOSS keyboards.
To make use of the leftover space under keyboard in this kind of situation, I would like to see 'corner buttons' described in the first post, but I understand that it's not prioritized. Thank you anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants