Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of accents for french (france) AZERTY #615

Closed
Bapt17 opened this issue Apr 11, 2021 · 2 comments · Fixed by #632
Closed

Position of accents for french (france) AZERTY #615

Bapt17 opened this issue Apr 11, 2021 · 2 comments · Fixed by #632
Assignees
@patrickgold
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Milestone
0.3.x

Comments

@Bapt17
Copy link

Bapt17 commented Apr 11, 2021

The order of accents for French (France) AZERTY is incorrect, this makes typing more complicated

Actual behavior:
IMG_20210411_192703
IMG_20210411_192635
IMG_20210411_192616
IMG_20210411_192548
IMG_20210411_192233
IMG_20210411_192103

Normal behavior (e.g. aosp keyboard):
IMG_20210411_192723
IMG_20210411_192520
IMG_20210411_192449
IMG_20210411_192418
IMG_20210411_192356
IMG_20210411_192326

Other than that the keyboard is awesome
@patrickgold
Copy link
Member

Thanks for your suggestion! Accent optimization has not yet been done for French, so I am very grateful for your detailed specifications on the order of the popups. Will add this to my todo list!

@patrickgold patrickgold added proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement labels Apr 12, 2021
@patrickgold patrickgold added this to the 0.4.0 milestone Apr 12, 2021
@patrickgold patrickgold self-assigned this Apr 12, 2021
patrickgold added a commit that referenced this issue Apr 12, 2021
@patrickgold
Improve French popups (#615)
267952d
@patrickgold patrickgold mentioned this issue Apr 12, 2021
Merged
@patrickgold
Copy link
Member

Above PR fixes the French popups for the most part. There's some issues with the ordering when the number is dynamically inserted but at least the primary accent is now 100% the one you provided your screenshots. Will be released in v0.3.11-beta01.

patrickgold added a commit that referenced this issue Apr 12, 2021
@patrickgold
Improve French popups (#615)
2534601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickgold patrickgold

Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Milestone
0.3.x
Development

Successfully merging a pull request may close this issue.

Improve French popups florisboard/florisboard
2 participants
@patrickgold @Bapt17