Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word deletion mode (after gliding) stays active on cursor move #916

Closed
pierstitus opened this issue May 21, 2021 · 4 comments · Fixed by #1844
Closed

Word deletion mode (after gliding) stays active on cursor move #916

pierstitus opened this issue May 21, 2021 · 4 comments · Fixed by #1844
Labels
area: glide-typing Glide typing frontend / backend bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@pierstitus
Copy link

Short description

After gliding a word, a single backspace press deletes the whole word. However if you move the cursor by tapping on the screen the word deletion mode stays active and backspace will delete the word were the cursor is moved to. In v0.3.10 this was also the case when moving the cursor by swiping the spacebar or when typing single characters. In v0.3.12 it's fixed for those two cases, but moving the cursor by tapping the screen still leaves the word deletion mode active.

This bug is also mentioned in #582 (comment)

Steps to reproduce

  1. Glide a word
  2. Tap on the screen to move the cursor to another word
  3. Press backspace, this removes the word, while it should remove a single letter like when the cursor is moved by swiping the spacebar.

Environment information

  • FlorisBoard Version: 0.3.12
  • Install Source: F-Droid/GitHub
@pierstitus pierstitus added the bug A bug report label May 21, 2021
@Glitchy-Tozier
Copy link
Collaborator

Present in v0.3.13, beta 6.
@X-yl May I add you again?

@X-yl
Copy link
Contributor

X-yl commented Jul 18, 2021

You know what, why not! I'll make a PR :)

@Glitchy-Tozier
Copy link
Collaborator

Yay, awesome! 😄

@patrickgold patrickgold added bug-confirmed A confirmed and reproducible bug report area: glide-typing Glide typing frontend / backend labels May 12, 2022
@patrickgold
Copy link
Member

Above linked commit/PR fixes the issue, the phantom space did not reset for unrelated selection updates, which caused this issue to occur. Will be released in 0.3.16-beta03, thanks for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: glide-typing Glide typing frontend / backend bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants