Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azerbaijani keyboard layout #1639

Conversation

nijatismayilzada
Copy link
Contributor

Hi,

I am now a fan of this project. Thanks for building this amazing keyboard.

As I am Azerbaijani, I have decided to add Azerbaijani layout support. I have basically copied the Turkish-Q layout, added our beloved "Ə" letter. I also moved the letters around according to the Azerbaijani Keyboard Layout standard.

ISO code AZ: https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes#AZ

I have tested the changes in Android Studio Virtual Machine with Pixel XL API 31 emulation. All working as expected.

Let me know if there is anything missing or any questions.

@patrickgold
Copy link
Member

patrickgold commented Mar 23, 2022

Sorry for the delay, your PR was made right in the final spurt for the 0.3.14 release, where I was fully focused on fixing bugs and actually making the stable release.

Now the release is done and I can focus again on reviewing PRs :) I just looked through your additions and everything looks fine. I will however still test it locally later, then merge in your changes.

Copy link
Member

@patrickgold patrickgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed your changes and your layout looks good.

I would like to request one thing though: Could you please add a subtype preset for Azerbaijani, so it will be available as a suggested subtype in the subtype add screen? Subtype presets are defined here: https://github.com/florisboard/florisboard/blob/master/app/src/main/assets/ime/keyboard/org.florisboard.localization/extension.json

Thanks!

Copy link
Member

@patrickgold patrickgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the subtype preset for you, so now the layout is ready for merging

@patrickgold patrickgold merged commit 4e8ff9e into florisboard:master Mar 25, 2022
@nijatismayilzada
Copy link
Contributor Author

Oh thanks, @patrickgold, I appreciate your time for reviewing and enhancing this with subtype presets! I am glad this is merged, looking forward to version 0.3.15!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants