Add Armenian keyboard layouts #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, really appreciate it! I've looked at the changes, and have found some issues. Will add a review comment to each of them so it is easier to reference. |
patrickgold
requested changes
Mar 23, 2022
app/src/main/assets/ime/keyboard/org.florisboard.localization/extension.json
Outdated
Show resolved
Hide resolved
app/src/main/assets/ime/keyboard/org.florisboard.layouts/extension.json
Outdated
Show resolved
Hide resolved
app/src/main/assets/ime/keyboard/org.florisboard.layouts/extension.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Goldinger <patrick@patrickgold.dev>
Co-authored-by: Patrick Goldinger <patrick@patrickgold.dev>
Co-authored-by: Patrick Goldinger <patrick@patrickgold.dev>
patrickgold
approved these changes
Mar 24, 2022
|
Will merge your changes now in, will be available in 0.3.15-beta01 tomorrow (Friday, may be today in your timezone already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for your work on this project.
I've added the Armenian Dram currency set, layouts for Eastern and Western Armenian, Armenian popup mappings, and Eastern and Western Armenian subtype presets.
Closes #492