Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new layout for Persian #1683

Merged
merged 3 commits into from
Mar 27, 2022
Merged

Adding new layout for Persian #1683

merged 3 commits into from
Mar 27, 2022

Conversation

mkoushan
Copy link
Contributor

Simply added new layout based on Swiftkey keyboard Persian layout. New popups too (I don't know it will work or not)

@patrickgold
Copy link
Member

Thanks for your PR!

I had to do a bit of cleanup due to multiple master merges into the PR, now cherry-picked the relevant changes and rebased on the current master state. I additionally fixed whitespace issues, your language code (fa-Fa-per2 does not work), and also added the characters mod to the extension.json file.

Tested it out locally and from a non-Persian speaking person everything checks out fine. Could you still please download the artifact APK of this PR to check when typing that the character placement and such is correct within the UI? Thanks!

@mkoushan
Copy link
Contributor Author

Thanks for fixing
I installed the PR artifact APK and i find out the popup for "half-space" key is not showing. I don't know how to fix it but i guess the issue is at app/src/main/assets/ime/keyboard/org.florisboard.localization/popupMappings/fa2.json Line 8:

...
      "‌": {
...

i think putting half_space instead of the actual character will fix it. but i'm not totally sure
Also i forgot to change the line 79 of the fa2.json file
pls remove the line 84 first ({ "code": 1567, "label": "؟"})
and change the line 79 to this:
"main": { "code": 1567, "label": "؟" },
thanks again.

@patrickgold
Copy link
Member

patrickgold commented Mar 27, 2022

i think putting half_space instead of the actual character will fix it

Yes putting half_space fixed the popups.

I also changed the lines 79 and 84 according to your instructions, everything should now be ok. Will merge in the changes now, thanks for your work!

Just a heads up: in your original Adding new layout Persian2 commit you used an email address (Gmail) which has not been added to your GitHub account. If you add it in the account's email options, you will be listed as the author, not me as GitHub incorrectly shows it.

@patrickgold patrickgold merged commit 66ddb45 into florisboard:master Mar 27, 2022
@patrickgold
Copy link
Member

Nevermind in the squash commit GitHub auto-uses your email used in your GitHub account, so no need to add it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants