Rework symbols sizing when number row is enabled #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to improve the symbols key and font sizing when the number row in the character layout is activated. The new key sizing calculation is now similar to Gboard's and thus the font-size bug is minimized and almost not noticeable anymore. Open to suggestions though if the new sizing method should be improved and tweaked a bit, as it now looks a bit different than before.
Comparison Old vs New
old_sizing.mp4
new_sizing.mp4
Closes #203 because there's no need to set different font sizes anymore as the bug's effect has been minimized and is now almost unnoticeable.