add tests to show Manifest can't be read from build/dist/plugin.jar #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floscher
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
@Gubaer Thank you very much for bringing this to my attention!
It probably has to do with the changes to how the MANIFEST.MF file is generated.
Java generates the manifest files as invalid UTF-8 files (see gradle/gradle#5225). That's why I wrote a custom implementation for creating the manifest files. Maybe the JarInputStream somewhere relies on the files being broken 🤔.
Edit: It looks like your explanation is probably the correct one.
I'll definitively have a look and fix that.
plugin/src/test/kotlin/org/openstreetmap/josm/gradle/plugin/demo/DemoTest.kt
Outdated
Show resolved
Hide resolved
Manifest can be read using JarFile::getManifest() Manifest can't be read using JarInputStream::getManifest() (the way JOSM does it) Possible reason: MANIFEST entry is at the end of the jar file, JarInputStream expects it at the beginning
floscher
force-pushed
the
bug-cant-read-manifest-using-jarinputstream
branch
from
f93cf37
to
b9f5fad
Compare
|
@Gubaer This should be fixed now and will be released as a new version ASAP. Thanks! |
floscher
force-pushed
the
bug-cant-read-manifest-using-jarinputstream
branch
from
b9f5fad
to
5212794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JarFile::getManifest()JarInputStream::getManifest()(the way JOSM does it)Possible reason: