Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

wait-for-git only gets killed after a polling period #10

Closed
flosell opened this issue Apr 3, 2016 · 0 comments
Closed

wait-for-git only gets killed after a polling period #10

flosell opened this issue Apr 3, 2016 · 0 comments

Comments

@flosell
Copy link
Owner

flosell commented Apr 3, 2016

To be killable, wait-for-git checks if it was killed before polling. This works ok if we poll often. However, since we now have web-hook support (#6), we don't need to poll that often anymore.

Result:

  • wait-for-git checks are in waiting state long after they were killed (e.g. because an either decided to do so)
  • Potentially strange history and warnings when killed by shutdown (Implement clean shutdown lambdacd#103)

Solution:
Make kill-check independent of polling

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant